1
0
mirror of https://github.com/golang/go synced 2024-11-18 16:14:46 -07:00
go/internal
Rebecca Stambler ab094738a9 internal/lsp: fix active parameter for incomplete parentheses
I had originally thought I might be able to use exprAtPos for this,
which is why I ended up eliminating that function when I saw it only had
one use.

One test also had to change in order to fit better with the spec.
Specifically: "If [the active parameter is] omitted or the value
lies outside the range of `signatures[activeSignature].parameters`
it defaults to 0 if the active signature has parameters."

Fixes golang/go#36766.

Change-Id: I400d5b2db2985bfaa5efbcd91225151ca8b5f46a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/216309
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-01-27 19:24:44 +00:00
..
apidiff all: fix more typos 2019-09-11 15:13:14 +00:00
fastwalk
gopathwalk internal/gopathwalk/walk: add missing function descriptions and renaming 2019-12-16 21:45:07 +00:00
imports internal/imports: pass dummy source for completion functions 2020-01-21 20:03:11 +00:00
jsonrpc2 internal/lsp/protocol: actually handle cancellation delivery 2020-01-24 22:04:29 +00:00
lsp internal/lsp: fix active parameter for incomplete parentheses 2020-01-27 19:24:44 +00:00
memoize internal/memoize: fix race on read of handle.function 2019-12-05 18:38:34 +00:00
module
packagesinternal go/packages: internally expose ForTests in go/packages 2020-01-16 22:11:50 +00:00
semver
span internal/span: support line directives 2019-11-25 19:20:43 +00:00
telemetry internal/telemetry/log: correct the docstring for Error 2020-01-21 22:25:47 +00:00
testenv internal/testenv: reject the resolved 'go' command if it does not match runtime.GOROOT 2019-11-11 19:22:22 +00:00
tool internal/lsp, internal/tool: clean up command line of gopls 2019-12-16 17:36:52 +00:00
xcontext internal/lsp: stop making background contexts everywhere 2019-07-11 16:38:52 +00:00