mirror of
https://github.com/golang/go
synced 2024-10-01 09:38:36 -06:00
3d17549cdc
This change adds a stub modFile struct for use in the future. It also moves the singleDiagnostic function out into the lsp package, so that the source package does not make decisions about what to show to the user as a diagnostic. Fixes golang/go#32221 Change-Id: I577c66fcd3c1daadaa221b52ff36bfa0fe07fb53 Reviewed-on: https://go-review.googlesource.com/c/tools/+/178681 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
102 lines
2.9 KiB
Go
102 lines
2.9 KiB
Go
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package lsp
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
"golang.org/x/tools/internal/lsp/source"
|
|
"golang.org/x/tools/internal/span"
|
|
)
|
|
|
|
func (s *Server) Diagnostics(ctx context.Context, v source.View, uri span.URI) {
|
|
if ctx.Err() != nil {
|
|
s.session.Logger().Errorf(ctx, "canceling diagnostics for %s: %v", uri, ctx.Err())
|
|
return
|
|
}
|
|
f, err := v.GetFile(ctx, uri)
|
|
if err != nil {
|
|
s.session.Logger().Errorf(ctx, "no file for %s: %v", uri, err)
|
|
return
|
|
}
|
|
// For non-Go files, don't return any diagnostics.
|
|
gof, ok := f.(source.GoFile)
|
|
if !ok {
|
|
return
|
|
}
|
|
reports, err := source.Diagnostics(ctx, v, gof)
|
|
if err != nil {
|
|
s.session.Logger().Errorf(ctx, "failed to compute diagnostics for %s: %v", gof.URI(), err)
|
|
return
|
|
}
|
|
|
|
s.undeliveredMu.Lock()
|
|
defer s.undeliveredMu.Unlock()
|
|
|
|
for uri, diagnostics := range reports {
|
|
if err := s.publishDiagnostics(ctx, v, uri, diagnostics); err != nil {
|
|
if s.undelivered == nil {
|
|
s.undelivered = make(map[span.URI][]source.Diagnostic)
|
|
}
|
|
s.undelivered[uri] = diagnostics
|
|
continue
|
|
}
|
|
// In case we had old, undelivered diagnostics.
|
|
delete(s.undelivered, uri)
|
|
}
|
|
// Anytime we compute diagnostics, make sure to also send along any
|
|
// undelivered ones (only for remaining URIs).
|
|
for uri, diagnostics := range s.undelivered {
|
|
err := s.publishDiagnostics(ctx, v, uri, diagnostics)
|
|
if err != nil {
|
|
s.session.Logger().Errorf(ctx, "failed to deliver diagnostic for %s: %v", uri, err)
|
|
}
|
|
// If we fail to deliver the same diagnostics twice, just give up.
|
|
delete(s.undelivered, uri)
|
|
}
|
|
}
|
|
|
|
func (s *Server) publishDiagnostics(ctx context.Context, view source.View, uri span.URI, diagnostics []source.Diagnostic) error {
|
|
protocolDiagnostics, err := toProtocolDiagnostics(ctx, view, diagnostics)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
s.client.PublishDiagnostics(ctx, &protocol.PublishDiagnosticsParams{
|
|
Diagnostics: protocolDiagnostics,
|
|
URI: protocol.NewURI(uri),
|
|
})
|
|
return nil
|
|
}
|
|
|
|
func toProtocolDiagnostics(ctx context.Context, v source.View, diagnostics []source.Diagnostic) ([]protocol.Diagnostic, error) {
|
|
reports := []protocol.Diagnostic{}
|
|
for _, diag := range diagnostics {
|
|
_, m, err := getSourceFile(ctx, v, diag.Span.URI())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
var severity protocol.DiagnosticSeverity
|
|
switch diag.Severity {
|
|
case source.SeverityError:
|
|
severity = protocol.SeverityError
|
|
case source.SeverityWarning:
|
|
severity = protocol.SeverityWarning
|
|
}
|
|
rng, err := m.Range(diag.Span)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
reports = append(reports, protocol.Diagnostic{
|
|
Message: strings.TrimSpace(diag.Message), // go list returns errors prefixed by newline
|
|
Range: rng,
|
|
Severity: severity,
|
|
Source: diag.Source,
|
|
})
|
|
}
|
|
return reports, nil
|
|
}
|