mirror of
https://github.com/golang/go
synced 2024-11-19 02:54:42 -07:00
de023d59a5
With #34111, we are forwarding the LSP from one gopls instance to another. This exposed an asymmetry in our LSP dispatching: for both ClientDispatcher and ServerDispatcher, we unmarshal to non-nil response structs. This means that when forwarding the LSP, we translate empty JSON responses (corresponding to nil values) into the non-nil zero value. This causes problems for some editors, as reported in #37570. Fix it by instead unmarshaling to a pointer. This is, of course, a somewhat dangerous change. I fixed the one NPE that occurred in tests, and have done some mild manual testing. I wouldn't be surprised if we discover more NPEs later on, but I still think this is the right change to make. Updates golang/go#34111 Fixes golang/go#37570 Change-Id: Ie69e92d2821c829cdfc4f4ab303679a725f1f859 Reviewed-on: https://go-review.googlesource.com/c/tools/+/222058 Reviewed-by: Peter Weinberger <pjw@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
45 lines
959 B
Go
45 lines
959 B
Go
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package regtest
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"testing"
|
|
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
)
|
|
|
|
const simpleProgram = `
|
|
-- go.mod --
|
|
module mod
|
|
|
|
go 1.12
|
|
-- main.go --
|
|
package main
|
|
|
|
import "fmt"
|
|
|
|
func main() {
|
|
fmt.Println("Hello World.")
|
|
}`
|
|
|
|
func TestHoverSerialization(t *testing.T) {
|
|
runner.Run(t, exampleProgram, func(ctx context.Context, t *testing.T, env *Env) {
|
|
// Hover on an empty line.
|
|
params := protocol.HoverParams{}
|
|
params.TextDocument.URI = env.W.URI("main.go")
|
|
params.Position.Line = 3
|
|
params.Position.Character = 0
|
|
var resp json.RawMessage
|
|
if err := env.Conn.Call(ctx, "textDocument/hover", ¶ms, &resp); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(string(resp)) > 0 {
|
|
t.Errorf("got non-empty response for empty hover: %v", string(resp))
|
|
}
|
|
})
|
|
}
|