Dan Scales a9a01a3fbd cmd/compile: remove now-unneeded SetHasTParam() for cached ptr element ... We had code in NewPtr() to set the HasTParam/HasShape flag as needed for the cached ptr element if it wasn't set correctly based on its Elem. This was causing the race mentioned in the issue. But that setting code is no longer needed, as long as we call SetRParams() soon after calling NewIncompleteNamedType(), before creating/translating the underlying type (which we do). The HasTParam/HasShape attribute can only come from setting of rparams or a direct typeparam/shape somewhere in the underlying type, both of which don't depend on recursion, etc. (as long as the rparams are set early). Added a check that HasTParam/HasShape are set correctly for the cached pointer/slice elems in NewPtr() and NewSlice(). Fixes #48191 Change-Id: Ide7d82efb77ae97901e75b2e6c65bd1bfc25e0ee Reviewed-on: https://go-review.googlesource.com/c/go/+/348089 Trust: Dan Scales <danscales@google.com> Run-TryBot: Dan Scales <danscales@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>		2021-09-07 22:23:36 +00:00
..
absdiffimp.dir	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
aliasimp.dir	cmd/compile/internal/types2: disallow aliases for generic types	2021-08-31 16:43:46 +00:00
chansimp.dir	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
dedup.dir	[dev.typeparams] cmd/compile: put shape types in their own package	2021-08-04 17:56:00 +00:00
factimp.dir	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
issue47514c.dir	cmd/compile: fix reference to generic type needed by crawler	2021-08-26 20:18:58 +00:00
issue47775.dir	cmd/compile: always remove receiver type from instantiated method values	2021-08-23 19:27:46 +00:00
issue47892.dir	test: add test cases for issue47892.	2021-08-29 14:10:21 +00:00
issue47892b.dir	test: add test cases for issue47892.	2021-08-29 14:10:21 +00:00
issue48094.dir	cmd/compile: builtins may be in the unsafe package	2021-08-31 17:21:38 +00:00
issue48185a.dir	cmd/compile: fix deadlock in (*Named).load	2021-09-07 17:38:14 +00:00
issue48185b.dir	cmd/compile: make sure imported instantiated types have their methods created	2021-09-07 20:37:05 +00:00
listimp2.dir	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
listimp.dir	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
mapimp.dir	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
mapsimp.dir
mdempsky	[dev.typeparams] cmd/compile: fixing case where type arg is an interface	2021-08-05 17:33:41 +00:00
mincheck.dir	[dev.typeparams] cmd/compile/internal/types2: implement type sets with term lists	2021-08-05 19:36:47 +00:00
minimp.dir	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
mutualimp.dir	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
orderedmapsimp.dir	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
pairimp.dir	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
setsimp.dir
sliceimp.dir	test/typeparam/sliceimp.dir: fix typo in a.go	2021-08-30 01:55:58 +00:00
stringerimp.dir
valimp.dir	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
absdiff.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
absdiffimp.go
adder.go
aliasimp.go
append.go	cmd/compile: disable type list syntax for the compiler	2021-09-02 01:06:17 +00:00
boundmethod.go	[dev.typeparams] cmd/compile: handle meth expressions on typeparams	2021-07-29 21:58:06 +00:00
builtins.go	[dev.typeparams] cmd/compile/internal/types2: fix make with type parameter argument	2021-08-06 20:34:46 +00:00
chans.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
chansimp.go
combine.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
cons.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
dedup.go	[dev.typeparams] cmd/compile: put shape types in their own package	2021-08-04 17:56:00 +00:00
dedup.out	[dev.typeparams] cmd/compile: put shape types in their own package	2021-08-04 17:56:00 +00:00
dictionaryCapture-noinline.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
dictionaryCapture.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
dottype.go	[dev.typeparams] cmd/compile: implement generic .(T) operations	2021-07-29 17:15:21 +00:00
dottype.out	[dev.typeparams] cmd/compile: implement generic .(T) operations	2021-07-29 17:15:21 +00:00
double.go	cmd/compile: disable type list syntax for the compiler	2021-09-02 01:06:17 +00:00
eface.go	cmd/compile: fix stenciling of conversions between interfaces	2021-08-27 16:41:29 +00:00
equal.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
fact.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
factimp.go
graph.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
ifaceconv.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
importtest.go
index.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
interfacearg.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
issue39755.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
issue44688.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
issue45547.go	[dev.typeparams] test: rename blank functions	2021-07-28 21:41:07 +00:00
issue45722.go
issue45738.go
issue45817.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
issue46472.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
issue46591.go	test/typeparam: add a test case for issue46591	2021-08-20 21:00:08 +00:00
issue47258.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
issue47272.go	cmd/compile: fix CONVIFACE case converting interface to empty interface	2021-08-17 13:23:13 +00:00
issue47272.out	cmd/compile: fix CONVIFACE case converting interface to empty interface	2021-08-17 13:23:13 +00:00
issue47514.go	[dev.typeparams] cmd/compile: make sure closures inside generic funcs are not compiled	2021-08-06 18:50:46 +00:00
issue47514b.go	[dev.typeparams] cmd/compile: call transformArgs before early typecheckaste in noder	2021-08-09 19:43:09 +00:00
issue47514c.go	cmd/compile: fix reference to generic type needed by crawler	2021-08-26 20:18:58 +00:00
issue47676.go	cmd/compile: fix handling of Defn field during stenciling	2021-08-31 19:07:50 +00:00
issue47684.go	cmd/compile: fix dictionaries for nested closures	2021-08-16 16:55:27 +00:00
issue47684b.go	cmd/compile: fix dictionaries for nested closures	2021-08-16 16:55:27 +00:00
issue47684c.go	cmd/compile: fix dictionaries for nested closures	2021-08-16 16:55:27 +00:00
issue47708.go	cmd/compile: fix conversions from TypeParam to interface	2021-09-01 16:45:26 +00:00
issue47710.go	cmd/compile: delay fillinMethods to deal with mutually-recursive types	2021-08-27 01:42:38 +00:00
issue47713.go	cmd/compile: fix naming of types inside instantiations	2021-08-24 18:30:13 +00:00
issue47713.out	cmd/compile: fix naming of types inside instantiations	2021-08-24 18:30:13 +00:00
issue47716.go	cmd/compile: fixes for non-constant Sizeof/Alignof/Offsetof	2021-08-23 22:55:34 +00:00
issue47723.go	cmd/compile: copy captured dictionary var to local var	2021-08-23 17:51:41 +00:00
issue47740.go	cmd/compile: only use dictionaries for conversions to type parameters	2021-08-18 22:34:31 +00:00
issue47740.out	cmd/compile: only use dictionaries for conversions to type parameters	2021-08-18 22:34:31 +00:00
issue47740b.go	cmd/compile: only use dictionaries for conversions to type parameters	2021-08-18 22:34:31 +00:00
issue47775.go	cmd/compile: always remove receiver type from instantiated method values	2021-08-23 19:27:46 +00:00
issue47775b.go	cmd/compile: always remove receiver type from instantiated method values	2021-08-23 19:27:46 +00:00
issue47877.go	cmd/compile: fix naming of types inside instantiations	2021-08-24 18:30:13 +00:00
issue47878.go	cmd/compile: fix stencil call expression.	2021-08-25 16:37:31 +00:00
issue47892.go	test: add test cases for issue47892.	2021-08-29 14:10:21 +00:00
issue47892b.go	test: add test cases for issue47892.	2021-08-29 14:10:21 +00:00
issue47896.go	cmd/compile: reuse same node for global dictionaries	2021-08-24 00:01:29 +00:00
issue47901.go	cmd/compile: fix CheckSize() calculation for -G=3 and stencils	2021-08-25 15:30:19 +00:00
issue47924.go	cmd/compile: mark ODYNAMICDOTTYPE as an expression that can panic	2021-08-24 18:31:34 +00:00
issue47925.go	cmd/compile: fix stenciling of conversions between interfaces	2021-08-27 16:41:29 +00:00
issue47925b.go	cmd/compile: fix stenciling of conversions between interfaces	2021-08-27 16:41:29 +00:00
issue47925c.go	cmd/compile: fix stenciling of conversions between interfaces	2021-08-27 16:41:29 +00:00
issue47925d.go	cmd/compile: fix stenciling of conversions between interfaces	2021-08-27 16:41:29 +00:00
issue47929.go	cmd/compile: fix CheckSize() calculation for -G=3 and stencils	2021-08-25 15:30:19 +00:00
issue47948.go	cmd/compile: fix function contains no TParam in generic function	2021-08-25 19:06:16 +00:00
issue47966.go	cmd/compile: support type C comparable	2021-08-28 16:00:51 +00:00
issue48013.go	cmd/compile: fix missing case for shape double-check function	2021-09-01 02:51:18 +00:00
issue48016.go	cmd/compile: fix handling of Defn field during stenciling	2021-08-31 19:07:50 +00:00
issue48030.go	cmd/compile: fix bug with Inferred targs	2021-08-30 21:22:35 +00:00
issue48042.go	cmd/compile: fix delay transformation in *subster.node()	2021-09-06 14:02:24 +00:00
issue48056.go	cmd/compile: fix error when revcType is ptr in selectorExpr	2021-08-30 17:13:00 +00:00
issue48094.go	cmd/compile: builtins may be in the unsafe package	2021-08-31 17:21:38 +00:00
issue48185a.go	cmd/compile: fix deadlock in (*Named).load	2021-09-07 17:38:14 +00:00
issue48185b.go	cmd/compile: make sure imported instantiated types have their methods created	2021-09-07 20:37:05 +00:00
issue48191.go	cmd/compile: remove now-unneeded SetHasTParam() for cached ptr element	2021-09-07 22:23:36 +00:00
issue48198.go	cmd/compile: make sure that the names created for instantiated type are the same	2021-09-07 03:56:13 +00:00
list2.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
list.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
listimp2.go
listimp.go
lockable.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
map.go
mapimp.go
maps.go
mapsimp.go
metrics.go
min.go
mincheck.go
minimp.go
mutualimp.go
nested.go	[dev.typeparams] test: add expected failure mechanism	2021-07-07 11:12:13 +00:00
nested.out
ordered.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
orderedmap.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
orderedmapsimp.go
pair.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
pairimp.go
pragma.go
sets.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
setsimp.go
settable.go	cmd/compile: disable type list syntax for the compiler	2021-09-02 01:06:17 +00:00
shape1.go	[dev.typeparams] cmd/compile: make all pointer types have the same shape	2021-07-31 17:03:07 +00:00
shape1.out	[dev.typeparams] cmd/compile: make all pointer types have the same shape	2021-07-31 17:03:07 +00:00
sliceimp.go
slices.go	all: fix typos	2021-08-17 13:54:10 +00:00
smallest.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
smoketest.go	cmd/compile: enable -G=3 by default	2021-08-21 00:24:02 +00:00
stringable.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
stringer.go
stringerimp.go
struct.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
subdict.go	cmd/compile: support type C comparable	2021-08-28 16:00:51 +00:00
sum.go	[dev.typeparams] test/typeparam: gofmt -w	2021-07-28 21:40:40 +00:00
tparam1.go	[dev.typeparams] cmd/compile/internal/types2: parameterized functions must have a body	2021-08-10 01:20:34 +00:00
typelist.go	cmd/compile: disable type list syntax for the compiler	2021-09-02 01:06:17 +00:00
typeswitch1.go	[dev.typeparams] cmd/compile: implement generic type switches	2021-08-09 18:41:45 +00:00
typeswitch1.out	[dev.typeparams] cmd/compile: implement generic type switches	2021-08-09 18:41:45 +00:00
typeswitch2.go	cmd/compile: fix handling of Defn field during stenciling	2021-08-31 19:07:50 +00:00
typeswitch2.out	[dev.typeparams] cmd/compile: implement generic type switches	2021-08-09 18:41:45 +00:00
typeswitch3.go	[dev.typeparams] cmd/compile: implement generic type switches	2021-08-09 18:41:45 +00:00
typeswitch3.out	[dev.typeparams] cmd/compile: implement generic type switches	2021-08-09 18:41:45 +00:00
typeswitch4.go	[dev.typeparams] cmd/compile: implement generic type switches	2021-08-09 18:41:45 +00:00
typeswitch4.out	[dev.typeparams] cmd/compile: implement generic type switches	2021-08-09 18:41:45 +00:00
typeswitch5.go	[dev.typeparams] cmd/compile: implement generic type switches	2021-08-09 18:41:45 +00:00
typeswitch5.out	[dev.typeparams] cmd/compile: implement generic type switches	2021-08-09 18:41:45 +00:00
typeswitch6.go	[dev.typeparams] cmd/compile: handle interface type parameters in type switches	2021-08-10 01:56:50 +00:00
typeswitch6.out	[dev.typeparams] cmd/compile: handle interface type parameters in type switches	2021-08-10 01:56:50 +00:00
typeswitch7.go	[dev.typeparams] cmd/compile: handle interface type parameters in type switches	2021-08-10 01:56:50 +00:00
typeswitch7.out	[dev.typeparams] cmd/compile: handle interface type parameters in type switches	2021-08-10 01:56:50 +00:00
valimp.go
value.go