mirror of
https://github.com/golang/go
synced 2024-11-18 16:54:43 -07:00
a8f40b3f4d
This changes the basic API of a jsonrpc2 connection to run the read loop as a method rather than in a go routine launched in the NewConn. This allows the handler to be created and bound between construction and the read loop starting, which fixes the race. Fixes golang/go#30091 Change-Id: I8201175affe431819cf473e5194d70c019f58425 Reviewed-on: https://go-review.googlesource.com/c/tools/+/170003 Run-TryBot: Ian Cottrell <iancottrell@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
52 lines
1.7 KiB
Go
52 lines
1.7 KiB
Go
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package protocol
|
|
|
|
import (
|
|
"context"
|
|
"log"
|
|
|
|
"golang.org/x/tools/internal/jsonrpc2"
|
|
)
|
|
|
|
func canceller(ctx context.Context, conn *jsonrpc2.Conn, req *jsonrpc2.Request) {
|
|
conn.Notify(context.Background(), "$/cancelRequest", &CancelParams{ID: *req.ID})
|
|
}
|
|
|
|
func NewClient(stream jsonrpc2.Stream, client Client) (*jsonrpc2.Conn, Server) {
|
|
conn := jsonrpc2.NewConn(stream)
|
|
conn.Handler = clientHandler(client)
|
|
conn.Canceler = jsonrpc2.Canceler(canceller)
|
|
return conn, &serverDispatcher{Conn: conn}
|
|
}
|
|
|
|
func NewServer(stream jsonrpc2.Stream, server Server) (*jsonrpc2.Conn, Client) {
|
|
conn := jsonrpc2.NewConn(stream)
|
|
conn.Handler = serverHandler(server)
|
|
conn.Canceler = jsonrpc2.Canceler(canceller)
|
|
return conn, &clientDispatcher{Conn: conn}
|
|
}
|
|
|
|
func sendParseError(ctx context.Context, conn *jsonrpc2.Conn, req *jsonrpc2.Request, err error) {
|
|
if _, ok := err.(*jsonrpc2.Error); !ok {
|
|
err = jsonrpc2.NewErrorf(jsonrpc2.CodeParseError, "%v", err)
|
|
}
|
|
unhandledError(conn.Reply(ctx, req, nil, err))
|
|
}
|
|
|
|
// unhandledError is used in places where an error may occur that cannot be handled.
|
|
// This occurs in things like rpc handlers that are a notify, where we cannot
|
|
// reply to the caller, or in a call when we are actually attempting to reply.
|
|
// In these cases, there is nothing we can do with the error except log it, so
|
|
// we do that in this function, and the presence of this function acts as a
|
|
// useful reminder of why we are effectively dropping the error and also a
|
|
// good place to hook in when debugging those kinds of errors.
|
|
func unhandledError(err error) {
|
|
if err == nil {
|
|
return
|
|
}
|
|
log.Printf("%v", err)
|
|
}
|