1
0
mirror of https://github.com/golang/go synced 2024-10-01 01:48:32 -06:00
go/internal/lsp/cmd
Ian Cottrell a8f40b3f4d internal/jsonrpc2: split main loop from construction to fix race
This changes the basic API of a jsonrpc2 connection to run the
read loop as a method rather than in a go routine launched in
the NewConn. This allows the handler to be created and bound
between construction and the read loop starting, which fixes
the race.

Fixes golang/go#30091

Change-Id: I8201175affe431819cf473e5194d70c019f58425
Reviewed-on: https://go-review.googlesource.com/c/tools/+/170003
Run-TryBot: Ian Cottrell <iancottrell@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-03-29 19:31:51 +00:00
..
check_test.go internal/lsp: allow command line tests to connect through a pipe 2019-03-29 15:12:06 +00:00
check.go internal/lsp: adding command line access to diagnostics 2019-03-28 21:17:00 +00:00
cmd_test.go internal/lsp: allow command line tests to connect through a pipe 2019-03-29 15:12:06 +00:00
cmd.go internal/jsonrpc2: split main loop from construction to fix race 2019-03-29 19:31:51 +00:00
definition_test.go internal/lsp: use main testdata folder 2019-03-26 19:49:56 +00:00
definition.go internal/lsp: fix broken gopls query help comment 2019-03-29 15:12:28 +00:00
export_test.go internal/lsp: refactor query definition test to allow adding a new test 2019-03-18 20:06:54 +00:00
query.go internal/lsp/cmd: fix a nil pointer and some minor clean-up 2019-02-06 04:15:39 +00:00
serve.go internal/jsonrpc2: split main loop from construction to fix race 2019-03-29 19:31:51 +00:00