1
0
mirror of https://github.com/golang/go synced 2024-11-11 18:21:40 -07:00
go/misc
Austin Clements a76b073712 misc/cgo/test: fix vet error
Vet's cgocall check fails on misc/cgo/test with "possibly passing Go
type with embedded pointer to C". This error is confusing, but the
cgocall check is looking for passing pointers to Go slices to C, which
is exactly what this test is doing. Normally we don't notice this
because vet doesn't run on misc, but we're about to move this test to
cmd/cgo/internal, where vet will start failing.

I'm not sure why we're passing a pointer to a slice here. It's
important that we call a C function with an unsafe.Pointer to memory
containing a pointer to test #25941 and that the result is this call
is then passed to another C function for #28540. This CL maintains
these two properties without the use of a slice.

For #37486.

Change-Id: I672a3c35931a59f99363050498d6f0c80fb6cd98
Reviewed-on: https://go-review.googlesource.com/c/go/+/493137
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
2023-05-12 11:59:58 +00:00
..
arm
cgo misc/cgo/test: fix vet error 2023-05-12 11:59:58 +00:00
chrome/gophertool docs: fix case of GitHub 2021-03-05 02:35:21 +00:00
go_android_exec misc/android: improve exit code workaround 2023-05-03 14:54:58 +00:00
ios all: gofmt main repo 2022-04-11 16:34:30 +00:00
linkcheck all: use bytes.Cut, strings.Cut 2021-10-06 15:53:04 +00:00
reboot make.{bash,bat}: check unmodified $PATH for $GOROOT/bin presence 2023-04-19 14:36:22 +00:00
swig
wasm misc/wasm: add wasmedge to wasip1 script 2023-05-11 14:42:30 +00:00
editors
go.mod misc: update go.mod to 1.21 2023-01-26 16:55:59 +00:00