1
0
mirror of https://github.com/golang/go synced 2024-11-19 10:14:44 -07:00
go/internal/lsp/cache
Rebecca Stambler 6fb6f5a9fc internal/lsp: never reload command-line-arguments directly
I'm not sure if this is entirely the correct approach, but at the very
least we should never pass "command-line-arguments" to packages.Load. We
still need to cache packages with the path "command-line-arguments" to
avoid an excessive number of calls to packages.Load.

Updates golang/go#37978

Change-Id: I1b5263a3dab95aacd797f03f742069fd0c53619c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/225117
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-03-24 17:58:52 +00:00
..
analysis.go internal/telemetry: add type safe tag keys 2020-03-18 13:29:43 +00:00
cache.go internal/lsp: move the debug.Instance onto the Context 2020-03-03 22:54:53 +00:00
check.go internal/telemetry: add type safe tag keys 2020-03-18 13:29:43 +00:00
debug.go internal/lsp/lsprpc: add a handshake between forwarder and remote 2020-02-24 22:51:04 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
external.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
load.go internal/lsp: never reload command-line-arguments directly 2020-03-24 17:58:52 +00:00
mod.go internal/lsp: fix nil pointer in 'go mod why' logic 2020-03-24 16:11:17 +00:00
parse.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
pkg.go internal/lsp: add module versions from "go list" to pkg.go.dev links 2020-02-19 19:55:21 +00:00
session.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
snapshot.go internal/lsp: never reload command-line-arguments directly 2020-03-24 17:58:52 +00:00
view.go internal/telemetry: delete the event.TagOf method 2020-03-18 13:23:15 +00:00