mirror of
https://github.com/golang/go
synced 2024-11-24 06:30:22 -07:00
eb54079264
The 'address taken' bit in a function variable was not propagating into the inlined copies, causing incorrect liveness information. LGTM=dsymonds, bradfitz R=golang-codereviews, bradfitz CC=dsymonds, golang-codereviews, iant, khr, r https://golang.org/cl/96670046
40 lines
840 B
Go
40 lines
840 B
Go
// errorcheck -0 -live
|
|
|
|
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// liveness tests with inlining ENABLED
|
|
// see also live.go.
|
|
|
|
package main
|
|
|
|
// issue 8142: lost 'addrtaken' bit on inlined variables.
|
|
// no inlining in this test, so just checking that non-inlined works.
|
|
|
|
type T40 struct {
|
|
m map[int]int
|
|
}
|
|
|
|
func newT40() *T40 {
|
|
ret := T40{ // ERROR "live at call to makemap: &ret"
|
|
make(map[int]int),
|
|
}
|
|
return &ret
|
|
}
|
|
|
|
func bad40() {
|
|
t := newT40() // ERROR "live at call to makemap: ret"
|
|
println() // ERROR "live at call to printnl: ret"
|
|
_ = t
|
|
}
|
|
|
|
func good40() {
|
|
ret := T40{ // ERROR "live at call to makemap: ret"
|
|
make(map[int]int),
|
|
}
|
|
t := &ret
|
|
println() // ERROR "live at call to printnl: ret"
|
|
_ = t
|
|
}
|