mirror of
https://github.com/golang/go
synced 2024-10-01 01:18:32 -06:00
7a2a8a0471
We had previously been ignoring many errors in textDocument/documentSymbols, which led to errors appearing in the VS Code extension logs (see https://github.com/microsoft/vscode-go/issues/2919 for more context). We should return errors so that we can more easily debug these issues in gopls directly. Change-Id: Ieef7c9f0bc8296f7e12d8c84e60d8b978d311651 Reviewed-on: https://go-review.googlesource.com/c/tools/+/209858 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
39 lines
1.1 KiB
Go
39 lines
1.1 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package lsp
|
|
|
|
import (
|
|
"context"
|
|
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
"golang.org/x/tools/internal/lsp/source"
|
|
"golang.org/x/tools/internal/lsp/telemetry"
|
|
"golang.org/x/tools/internal/span"
|
|
"golang.org/x/tools/internal/telemetry/log"
|
|
"golang.org/x/tools/internal/telemetry/trace"
|
|
)
|
|
|
|
func (s *Server) documentSymbol(ctx context.Context, params *protocol.DocumentSymbolParams) ([]protocol.DocumentSymbol, error) {
|
|
ctx, done := trace.StartSpan(ctx, "lsp.Server.documentSymbol")
|
|
defer done()
|
|
|
|
uri := span.NewURI(params.TextDocument.URI)
|
|
view, err := s.session.ViewOf(uri)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
snapshot := view.Snapshot()
|
|
f, err := view.GetFile(ctx, uri)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
symbols, err := source.DocumentSymbols(ctx, snapshot, f)
|
|
if err != nil {
|
|
log.Error(ctx, "DocumentSymbols failed", err, telemetry.URI.Of(uri))
|
|
return []protocol.DocumentSymbol{}, nil
|
|
}
|
|
return symbols, nil
|
|
}
|