mirror of
https://github.com/golang/go
synced 2024-11-18 11:04:42 -07:00
7e40e1726e
- show signature for function calls whose function expression is not an object (e.g. the second call in foo()()). since the function name is not available, we use the generic "func" - only provide signature help when the position is on or within the call expression parens. this is consistent with the one other lsp server i tried (java). this improves the gopls experience in emacs where lsp-mode is constantly calling "hover" and "signatureHelp" ("hover" should be preferred unless you are inside the function params list) - use the entire signature type string as the label since that includes the return values, which are useful to see - don't qualify the function name with its package. it looks funny to see "bytes.Cap()" as the help when you are in a call to (*bytes.Buffer).Cap(). it could be useful to include invocant type info, but leave it out for now since signature help is meant to focus on the function parameters. - don't turn variadic args "foo ...int" into "foo []int" for the parameter information (i.e. maintain it as "foo ...int") - when determining active parameter, count the space before a parameter name as being part of that parameter (e.g. the space before "b" in "func(a int, b int)") - handle variadic params when determining the active param (i.e. highlight "foo(a int, *b ...string*)" on signature help for final param in `foo(123, "a", "b", "c")` - don't generate an extra space in formatParams() for unnamed arguments I also tweaked the signatureHelp server log message to include the error message itself, and populated the server's logger in lsp_test.go to aid in development. Fixes golang/go#31448 Change-Id: Iefe0e1e3c531d17197c0fa997b949174475a276c GitHub-Last-Rev: 5c0b8ebd87a8c05d5d8f519ea096f94e89c77e2c GitHub-Pull-Request: golang/tools#82 Reviewed-on: https://go-review.googlesource.com/c/tools/+/172439 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
139 lines
3.8 KiB
Go
139 lines
3.8 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package span
|
|
|
|
import (
|
|
"fmt"
|
|
"go/token"
|
|
)
|
|
|
|
// Range represents a source code range in token.Pos form.
|
|
// It also carries the FileSet that produced the positions, so that it is
|
|
// self contained.
|
|
type Range struct {
|
|
FileSet *token.FileSet
|
|
Start token.Pos
|
|
End token.Pos
|
|
}
|
|
|
|
// TokenConverter is a Converter backed by a token file set and file.
|
|
// It uses the file set methods to work out the conversions, which
|
|
// makes it fast and does not require the file contents.
|
|
type TokenConverter struct {
|
|
fset *token.FileSet
|
|
file *token.File
|
|
}
|
|
|
|
// NewRange creates a new Range from a FileSet and two positions.
|
|
// To represent a point pass a 0 as the end pos.
|
|
func NewRange(fset *token.FileSet, start, end token.Pos) Range {
|
|
return Range{
|
|
FileSet: fset,
|
|
Start: start,
|
|
End: end,
|
|
}
|
|
}
|
|
|
|
// NewTokenConverter returns an implementation of Converter backed by a
|
|
// token.File.
|
|
func NewTokenConverter(fset *token.FileSet, f *token.File) *TokenConverter {
|
|
return &TokenConverter{fset: fset, file: f}
|
|
}
|
|
|
|
// NewContentConverter returns an implementation of Converter for the
|
|
// given file content.
|
|
func NewContentConverter(filename string, content []byte) *TokenConverter {
|
|
fset := token.NewFileSet()
|
|
f := fset.AddFile(filename, -1, len(content))
|
|
f.SetLinesForContent(content)
|
|
return &TokenConverter{fset: fset, file: f}
|
|
}
|
|
|
|
// IsPoint returns true if the range represents a single point.
|
|
func (r Range) IsPoint() bool {
|
|
return r.Start == r.End
|
|
}
|
|
|
|
// Span converts a Range to a Span that represents the Range.
|
|
// It will fill in all the members of the Span, calculating the line and column
|
|
// information.
|
|
func (r Range) Span() (Span, error) {
|
|
f := r.FileSet.File(r.Start)
|
|
if f == nil {
|
|
return Span{}, fmt.Errorf("file not found in FileSet")
|
|
}
|
|
s := Span{v: span{URI: FileURI(f.Name())}}
|
|
var err error
|
|
s.v.Start.Offset, err = offset(f, r.Start)
|
|
if err != nil {
|
|
return Span{}, err
|
|
}
|
|
if r.End.IsValid() {
|
|
s.v.End.Offset, err = offset(f, r.End)
|
|
if err != nil {
|
|
return Span{}, err
|
|
}
|
|
}
|
|
s.v.Start.clean()
|
|
s.v.End.clean()
|
|
s.v.clean()
|
|
converter := NewTokenConverter(r.FileSet, f)
|
|
return s.WithPosition(converter)
|
|
}
|
|
|
|
// offset is a copy of the Offset function in go/token, but with the adjustment
|
|
// that it does not panic on invalid positions.
|
|
func offset(f *token.File, pos token.Pos) (int, error) {
|
|
if int(pos) < f.Base() || int(pos) > f.Base()+f.Size() {
|
|
return 0, fmt.Errorf("invalid pos")
|
|
}
|
|
return int(pos) - f.Base(), nil
|
|
}
|
|
|
|
// Range converts a Span to a Range that represents the Span for the supplied
|
|
// File.
|
|
func (s Span) Range(converter *TokenConverter) (Range, error) {
|
|
s, err := s.WithOffset(converter)
|
|
if err != nil {
|
|
return Range{}, err
|
|
}
|
|
return Range{
|
|
FileSet: converter.fset,
|
|
Start: converter.file.Pos(s.Start().Offset()),
|
|
End: converter.file.Pos(s.End().Offset()),
|
|
}, nil
|
|
}
|
|
|
|
func (l *TokenConverter) ToPosition(offset int) (int, int, error) {
|
|
//TODO: check offset fits in file
|
|
pos := l.file.Pos(offset)
|
|
p := l.fset.Position(pos)
|
|
return p.Line, p.Column, nil
|
|
}
|
|
|
|
func (l *TokenConverter) ToOffset(line, col int) (int, error) {
|
|
if line < 0 {
|
|
return -1, fmt.Errorf("line is not valid")
|
|
}
|
|
lineMax := l.file.LineCount() + 1
|
|
if line > lineMax {
|
|
return -1, fmt.Errorf("line is beyond end of file")
|
|
} else if line == lineMax {
|
|
if col > 1 {
|
|
return -1, fmt.Errorf("column is beyond end of file")
|
|
}
|
|
// at the end of the file, allowing for a trailing eol
|
|
return l.file.Size(), nil
|
|
}
|
|
pos := lineStart(l.file, line)
|
|
if !pos.IsValid() {
|
|
return -1, fmt.Errorf("line is not in file")
|
|
}
|
|
// we assume that column is in bytes here, and that the first byte of a
|
|
// line is at column 1
|
|
pos += token.Pos(col - 1)
|
|
return offset(l.file, pos)
|
|
}
|