1
0
mirror of https://github.com/golang/go synced 2024-11-19 01:14:39 -07:00
go/internal/lsp/mod
Rebecca Stambler 9c79f685b7 internal/lsp: fix view rebuilding when go mod init runs
https://github.com/microsoft/vscode-go/issues/3076#issuecomment-605062933
inspired me to write a regression test for this case. Turns out we
weren't handling it correctly after all...

This change makes sure that we only rebuild the view once a new go.mod
file is saved, not just created. It also preserves the snapshot ID
number when the view is recreated so that diagnostic caching continues
to work as expected.

Change-Id: I63bd559c3bd33b91828171cd7ddb3d099c31cddb
Reviewed-on: https://go-review.googlesource.com/c/tools/+/226017
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-30 17:42:33 +00:00
..
testdata/unchanged internal/lsp/tests: fix reset of golden files 2020-02-19 14:42:13 +00:00
code_lens.go internal/telemetry: add type safe tag keys 2020-03-18 13:29:43 +00:00
diagnostics.go internal/lsp: fix view rebuilding when go mod init runs 2020-03-30 17:42:33 +00:00
format.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
hover.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
mod_test.go internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00