mirror of
https://github.com/golang/go
synced 2024-11-22 14:24:45 -07:00
8f19394b62
Based on https://golang.org/cl/284256 for go/types. Brings this code more in line with go/types. Adjusted various tests to match new error messages which generally are now better: for assignment errors, instead of a generic "cannot convert" we now say "cannot use" followed by a clearer reason as to why not. Major differences to go/types with respect to the changed files: - Some of the new code now returns error codes, but they are only used internally for now, and not reported with errors. - go/types does not "convert" untyped nil values to target types, but here we do. This is unchanged from how types2 handled this before this CL. Change-Id: If45336d7ee679ece100f6d9d9f291a6ea55004d8 Reviewed-on: https://go-review.googlesource.com/c/go/+/302757 Trust: Robert Griesemer <gri@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
75 lines
2.4 KiB
Go
75 lines
2.4 KiB
Go
// errorcheck
|
|
|
|
// Copyright 2009 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Verify that illegal assignments with both explicit and implicit conversions of literals are detected.
|
|
// Does not compile.
|
|
|
|
package main
|
|
|
|
import "unsafe"
|
|
|
|
// explicit conversion of constants
|
|
var x1 = string(1)
|
|
var x2 string = string(1)
|
|
var x3 = int(1.5) // ERROR "convert|truncate"
|
|
var x4 int = int(1.5) // ERROR "convert|truncate"
|
|
var x5 = "a" + string(1)
|
|
var x6 = int(1e100) // ERROR "overflow|cannot convert"
|
|
var x7 = float32(1e1000) // ERROR "overflow|cannot convert"
|
|
|
|
// unsafe.Pointer can only convert to/from uintptr
|
|
var _ = string(unsafe.Pointer(uintptr(65))) // ERROR "convert|conversion"
|
|
var _ = float64(unsafe.Pointer(uintptr(65))) // ERROR "convert|conversion"
|
|
var _ = int(unsafe.Pointer(uintptr(65))) // ERROR "convert|conversion"
|
|
|
|
// implicit conversions merit scrutiny
|
|
var s string
|
|
var bad1 string = 1 // ERROR "conver|incompatible|invalid|cannot"
|
|
var bad2 = s + 1 // ERROR "conver|incompatible|invalid|cannot"
|
|
var bad3 = s + 'a' // ERROR "conver|incompatible|invalid|cannot"
|
|
var bad4 = "a" + 1 // ERROR "literals|incompatible|convert|invalid"
|
|
var bad5 = "a" + 'a' // ERROR "literals|incompatible|convert|invalid"
|
|
|
|
var bad6 int = 1.5 // ERROR "convert|truncate"
|
|
var bad7 int = 1e100 // ERROR "overflow|truncated to int|truncated"
|
|
var bad8 float32 = 1e200 // ERROR "overflow"
|
|
|
|
// but these implicit conversions are okay
|
|
var good1 string = "a"
|
|
var good2 int = 1.0
|
|
var good3 int = 1e9
|
|
var good4 float64 = 1e20
|
|
|
|
// explicit conversion of string is okay
|
|
var _ = []rune("abc")
|
|
var _ = []byte("abc")
|
|
|
|
// implicit is not
|
|
var _ []int = "abc" // ERROR "cannot use|incompatible|invalid|cannot convert"
|
|
var _ []byte = "abc" // ERROR "cannot use|incompatible|invalid|cannot convert"
|
|
|
|
// named string is okay
|
|
type Tstring string
|
|
|
|
var ss Tstring = "abc"
|
|
var _ = []rune(ss)
|
|
var _ = []byte(ss)
|
|
|
|
// implicit is still not
|
|
var _ []rune = ss // ERROR "cannot use|incompatible|invalid"
|
|
var _ []byte = ss // ERROR "cannot use|incompatible|invalid"
|
|
|
|
// named slice is now ok
|
|
type Trune []rune
|
|
type Tbyte []byte
|
|
|
|
var _ = Trune("abc") // ok
|
|
var _ = Tbyte("abc") // ok
|
|
|
|
// implicit is still not
|
|
var _ Trune = "abc" // ERROR "cannot use|incompatible|invalid|cannot convert"
|
|
var _ Tbyte = "abc" // ERROR "cannot use|incompatible|invalid|cannot convert"
|