a1c56757aa
The Tagger interface allowed for specifying a key in a tag list and having the value be aquired from the context automatically. It was almost never used, and the alternative (using the key to get the value) is not that much more long winded, so it was not holding it's own weight from a complexity persective alone but the performance cost of having to use a list of interface rather than a list of tags was very large. See the benchstat improvements below for the difference it makes to both speed and memory usage, especially in the no exporter case. name old time/op new time/op delta Baseline-8 341ns ± 2% 342ns ± 1% ~ (p=0.139 n=19+18) LoggingNoExporter-8 2.46µs ± 5% 1.97µs ± 3% -19.88% (p=0.000 n=19+20) Logging-8 13.3µs ± 2% 12.8µs ± 2% -3.42% (p=0.000 n=17+20) LoggingStdlib-8 5.39µs ± 6% 5.34µs ± 3% ~ (p=0.692 n=20+19) name old alloc/op new alloc/op delta Baseline-8 80.0B ± 0% 80.0B ± 0% ~ (all equal) LoggingNoExporter-8 728B ± 0% 440B ± 0% -39.56% (p=0.000 n=20+20) Logging-8 2.75kB ± 0% 2.46kB ± 0% -10.53% (p=0.000 n=17+20) LoggingStdlib-8 568B ± 0% 568B ± 0% ~ (all equal) name old allocs/op new allocs/op delta Baseline-8 5.00 ± 0% 5.00 ± 0% ~ (all equal) LoggingNoExporter-8 32.0 ± 0% 23.0 ± 0% -28.12% (p=0.000 n=20+20) Logging-8 88.0 ± 0% 79.0 ± 0% -10.23% (p=0.000 n=20+20) LoggingStdlib-8 28.0 ± 0% 28.0 ± 0% ~ (all equal) Change-Id: Ic203ad0c5de7451348976b999a0d038ac532dc39 Reviewed-on: https://go-review.googlesource.com/c/tools/+/221737 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> |
||
|---|---|---|
| benchmark/parse | ||
| blog | ||
| cmd | ||
| container/intsets | ||
| cover | ||
| go | ||
| godoc | ||
| gopls | ||
| imports | ||
| internal | ||
| playground | ||
| present | ||
| refactor | ||
| txtar | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| go.mod | ||
| go.sum | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
Go Tools
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go
distributions.
Others, including the Go guru and the test coverage tool, can be fetched with
go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
Download/Install
The easiest way to install is to run go get -u golang.org/x/tools/.... You can
also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
Report Issues / Send Patches
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with "x/tools/(your subdir):" in the subject line, so it is easy to find.