Rebecca Stambler ab094738a9 internal/lsp: fix active parameter for incomplete parentheses ... I had originally thought I might be able to use exprAtPos for this, which is why I ended up eliminating that function when I saw it only had one use. One test also had to change in order to fit better with the spec. Specifically: "If [the active parameter is] omitted or the value lies outside the range of `signatures[activeSignature].parameters` it defaults to 0 if the active signature has parameters." Fixes golang/go#36766. Change-Id: I400d5b2db2985bfaa5efbcd91225151ca8b5f46a Reviewed-on: https://go-review.googlesource.com/c/tools/+/216309 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>		2020-01-27 19:24:44 +00:00
..
signature2.go.golden	internal/lsp: fix active parameter for incomplete parentheses	2020-01-27 19:24:44 +00:00
signature2.go.in	internal/lsp: fix active parameter for incomplete parentheses	2020-01-27 19:24:44 +00:00
signature.go	internal/lsp: fix active parameter for incomplete parentheses	2020-01-27 19:24:44 +00:00
signature.go.golden	tools/gopls: add cmd support for signature	2019-10-31 22:07:37 +00:00