mirror of
https://github.com/golang/go
synced 2024-11-05 22:26:10 -07:00
9ea0146da6
It was not very useful, it basically renamed io.EOF under some limited circumstances, and was only there for the befit of tests. Instead, the test now checks io.EOF directly, but also checks for io.ErrClosedPipe which was also happening. We also make sure we wrap errors rather than replacing them. This prevents some weird random test failures due to races in the way they were closed. Change-Id: I236b03ac5ba16bf763299b95d882cf58b1f74776 Reviewed-on: https://go-review.googlesource.com/c/tools/+/230303 Run-TryBot: Ian Cottrell <iancottrell@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
167 lines
4.6 KiB
Go
167 lines
4.6 KiB
Go
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package jsonrpc2_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"flag"
|
|
"fmt"
|
|
"io"
|
|
"path"
|
|
"reflect"
|
|
"sync"
|
|
"testing"
|
|
|
|
"golang.org/x/tools/internal/event/export/eventtest"
|
|
"golang.org/x/tools/internal/jsonrpc2"
|
|
)
|
|
|
|
var logRPC = flag.Bool("logrpc", false, "Enable jsonrpc2 communication logging")
|
|
|
|
type callTest struct {
|
|
method string
|
|
params interface{}
|
|
expect interface{}
|
|
}
|
|
|
|
var callTests = []callTest{
|
|
{"no_args", nil, true},
|
|
{"one_string", "fish", "got:fish"},
|
|
{"one_number", 10, "got:10"},
|
|
{"join", []string{"a", "b", "c"}, "a/b/c"},
|
|
//TODO: expand the test cases
|
|
}
|
|
|
|
func (test *callTest) newResults() interface{} {
|
|
switch e := test.expect.(type) {
|
|
case []interface{}:
|
|
var r []interface{}
|
|
for _, v := range e {
|
|
r = append(r, reflect.New(reflect.TypeOf(v)).Interface())
|
|
}
|
|
return r
|
|
case nil:
|
|
return nil
|
|
default:
|
|
return reflect.New(reflect.TypeOf(test.expect)).Interface()
|
|
}
|
|
}
|
|
|
|
func (test *callTest) verifyResults(t *testing.T, results interface{}) {
|
|
if results == nil {
|
|
return
|
|
}
|
|
val := reflect.Indirect(reflect.ValueOf(results)).Interface()
|
|
if !reflect.DeepEqual(val, test.expect) {
|
|
t.Errorf("%v:Results are incorrect, got %+v expect %+v", test.method, val, test.expect)
|
|
}
|
|
}
|
|
|
|
func TestCall(t *testing.T) {
|
|
ctx := eventtest.NewContext(context.Background(), t)
|
|
for _, headers := range []bool{false, true} {
|
|
name := "Plain"
|
|
if headers {
|
|
name = "Headers"
|
|
}
|
|
t.Run(name, func(t *testing.T) {
|
|
ctx := eventtest.NewContext(ctx, t)
|
|
a, b, done := prepare(ctx, t, headers)
|
|
defer done()
|
|
for _, test := range callTests {
|
|
t.Run(test.method, func(t *testing.T) {
|
|
ctx := eventtest.NewContext(ctx, t)
|
|
results := test.newResults()
|
|
if _, err := a.Call(ctx, test.method, test.params, results); err != nil {
|
|
t.Fatalf("%v:Call failed: %v", test.method, err)
|
|
}
|
|
test.verifyResults(t, results)
|
|
if _, err := b.Call(ctx, test.method, test.params, results); err != nil {
|
|
t.Fatalf("%v:Call failed: %v", test.method, err)
|
|
}
|
|
test.verifyResults(t, results)
|
|
})
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func prepare(ctx context.Context, t *testing.T, withHeaders bool) (*jsonrpc2.Conn, *jsonrpc2.Conn, func()) {
|
|
// make a wait group that can be used to wait for the system to shut down
|
|
wg := &sync.WaitGroup{}
|
|
aR, bW := io.Pipe()
|
|
bR, aW := io.Pipe()
|
|
a := run(ctx, t, withHeaders, aR, aW, wg)
|
|
b := run(ctx, t, withHeaders, bR, bW, wg)
|
|
return a, b, func() {
|
|
// we close the main writer, this should cascade through the server and
|
|
// cause normal shutdown of the entire chain
|
|
aW.Close()
|
|
// this should then wait for that entire cascade,
|
|
wg.Wait()
|
|
}
|
|
}
|
|
|
|
func run(ctx context.Context, t *testing.T, withHeaders bool, r io.ReadCloser, w io.WriteCloser, wg *sync.WaitGroup) *jsonrpc2.Conn {
|
|
var stream jsonrpc2.Stream
|
|
if withHeaders {
|
|
stream = jsonrpc2.NewHeaderStream(r, w)
|
|
} else {
|
|
stream = jsonrpc2.NewStream(r, w)
|
|
}
|
|
conn := jsonrpc2.NewConn(stream)
|
|
wg.Add(1)
|
|
go func() {
|
|
defer func() {
|
|
// this will happen when Run returns, which means at least one of the
|
|
// streams has already been closed
|
|
// we close both streams anyway, this may be redundant but is safe
|
|
r.Close()
|
|
w.Close()
|
|
// and then signal that this connection is done
|
|
wg.Done()
|
|
}()
|
|
err := conn.Run(ctx, testHandler(*logRPC))
|
|
if err != nil && !errors.Is(err, io.EOF) && !errors.Is(err, io.ErrClosedPipe) {
|
|
t.Errorf("Stream failed: %v", err)
|
|
}
|
|
}()
|
|
return conn
|
|
}
|
|
|
|
func testHandler(log bool) jsonrpc2.Handler {
|
|
return func(ctx context.Context, reply jsonrpc2.Replier, req jsonrpc2.Request) error {
|
|
switch req.Method() {
|
|
case "no_args":
|
|
if len(req.Params()) > 0 {
|
|
return reply(ctx, nil, fmt.Errorf("%w: expected no params", jsonrpc2.ErrInvalidParams))
|
|
}
|
|
return reply(ctx, true, nil)
|
|
case "one_string":
|
|
var v string
|
|
if err := json.Unmarshal(req.Params(), &v); err != nil {
|
|
return reply(ctx, nil, fmt.Errorf("%w: %s", jsonrpc2.ErrParse, err))
|
|
}
|
|
return reply(ctx, "got:"+v, nil)
|
|
case "one_number":
|
|
var v int
|
|
if err := json.Unmarshal(req.Params(), &v); err != nil {
|
|
return reply(ctx, nil, fmt.Errorf("%w: %s", jsonrpc2.ErrParse, err))
|
|
}
|
|
return reply(ctx, fmt.Sprintf("got:%d", v), nil)
|
|
case "join":
|
|
var v []string
|
|
if err := json.Unmarshal(req.Params(), &v); err != nil {
|
|
return reply(ctx, nil, fmt.Errorf("%w: %s", jsonrpc2.ErrParse, err))
|
|
}
|
|
return reply(ctx, path.Join(v...), nil)
|
|
default:
|
|
return jsonrpc2.MethodNotFound(ctx, reply, req)
|
|
}
|
|
}
|
|
}
|