1
0
mirror of https://github.com/golang/go synced 2024-11-07 10:46:18 -07:00
go/src
Rob Findley 9e8a312b71 go/parser: move type params in scope for the function signature
Type parameter resolution is a bit tricky: type parameters are in the
function scope, but unlike ordinary parameters may reference eachother.
When resolving the function scope, we must be careful about the order in
which objects are resolved and declared.

Using ordering allows us to avoid passing around temporary scopes for
field declarations.

Add a bunch of tests for this behavior, and skip "_" in resolution tests
as it just adds noise.

For #45221

Change-Id: Id080cddce3fd76396bf86ba5aba856aedf64a458
Reviewed-on: https://go-review.googlesource.com/c/go/+/304456
Trust: Robert Findley <rfindley@google.com>
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
2021-04-16 21:19:23 +00:00
..
archive archive/tar: replace os.MkdirTemp with T.TempDir 2021-04-13 21:06:12 +00:00
bufio
builtin
bytes
cmd cmd/compile: in clobberdead mode, don't clobber slots that are live for defers 2021-04-16 20:56:09 +00:00
compress
container
context
crypto crypto/tls: fix flaky handshake cancellation tests 2021-04-16 19:23:29 +00:00
database/sql
debug all: simplify the spelling of Linux 2021-04-13 13:56:21 +00:00
embed
encoding
errors
expvar
flag
fmt
go go/parser: move type params in scope for the function signature 2021-04-16 21:19:23 +00:00
hash
html
image
index/suffixarray
internal internal/buildcfg: move build configuration out of cmd/internal/objabi 2021-04-16 19:20:53 +00:00
io
log
math math: avoid assembly stubs 2021-04-15 15:48:19 +00:00
mime mime: keep builtinTypesLower sorted alphabetically 2021-04-15 10:21:10 +00:00
net net/http/fcgi: eliminate race, keep request id until end of stdin 2021-04-16 19:34:33 +00:00
os os/exec: replace os.Setenv with T.Setenv 2021-04-14 19:25:38 +00:00
path
plugin
reflect reflect: preserve ctxt across moveMakeFuncArgPtrs 2021-04-16 20:18:11 +00:00
regexp
runtime runtime: clarify which work needs spinning coordination 2021-04-16 21:04:16 +00:00
sort
strconv strconv: Implement Ryū algorithm for ftoa shortest mode 2021-04-15 09:18:03 +00:00
strings
sync
syscall syscall: don't defer close raw Socketpair fds in tests 2021-04-14 05:49:15 +00:00
testdata
testing
text text/template: replace os.MkdirTemp with T.TempDir 2021-04-12 21:58:25 +00:00
time time: add missing "os" import to zoneinfo_test.go 2021-04-15 00:40:43 +00:00
unicode
unsafe
vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod
go.sum
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.