Muir Manders 89082a3841 internal/lsp/source: fix some invalid literal candidates ... We were marking all literal candidates as addressable so we were getting invalid candidates like "&int()". Fix it to only mark literal struct, array, slice and map types as addressable. I also fixed the unnamed literal candidate to pass the dereferenced expected type. For example, if the expected type was "*[]int" we were passing a literal type of "*[]int" which wasn't working anymore. Now we pass "[]int" and take its address as "&[]int{}". Change-Id: I5d0ee074d3cc91c39dd881630583e31be5a05579 Reviewed-on: https://go-review.googlesource.com/c/tools/+/212677 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-01-08 20:36:44 +00:00
..
address	internal/lsp: trim address operator from completion filterText	2019-12-24 05:57:32 +00:00
analyzer	go/analysis: rename reportNodef to ReportRangef	2019-10-28 19:16:33 +00:00
anon
append	internal/lsp: improve completion in append() calls	2019-11-09 21:27:01 +00:00
arraytype	internal/lsp: improve completion for *ast.ArrayTypes	2019-10-23 16:34:50 +00:00
assign	internal/lsp/source: improve completion in value spec	2019-12-23 21:16:02 +00:00
bad	internal/lsp/source: fix all types in resolveInvalid	2019-12-11 23:00:51 +00:00
badstmt	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
bar	internal/lsp: improve completion for *ast.ArrayTypes	2019-10-23 16:34:50 +00:00
basiclit
baz	internal/lsp: search candidate type's package for completions	2019-10-30 06:26:58 +00:00
builtins	internal/lsp/source: don't downrank builtin constant completions	2020-01-07 18:15:58 +00:00
casesensitive
cast
cgo	internal/lsp/tests: skip cgo tests when not supported	2019-11-25 21:54:41 +00:00
cgoimport	internal/lsp: improve link in documentation on hover	2019-12-12 22:39:21 +00:00
channel	internal/lsp: support taking address for completion candidates	2019-12-23 23:54:10 +00:00
circular	internal/lsp: add diagnostic on import causing import cycle	2019-12-13 19:54:01 +00:00
comments
complit	internal/lsp: add comment completions for exported vars	2019-12-10 22:11:41 +00:00
constant
deep	internal/lsp: sort by label after score	2019-12-30 21:11:21 +00:00
errors
fieldlist
folding	tools/gopls: add cmd support for folding_ranges	2019-11-12 00:55:09 +00:00
foo	internal/lsp: fix bad *ast.ArrayTypes for completion	2019-10-17 20:53:01 +00:00
format	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
func_rank
funcsig
funcvalue
fuzzymatch	internal/lsp: reorganize and refactor code	2019-11-21 02:33:28 +00:00
generated	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
godef	internal/lsp: show comments for grouped variable declarations	2019-12-18 20:39:36 +00:00
good
highlights	internal/lsp: fix highlighting of inexact matches when highlighting from the right	2019-12-19 19:05:06 +00:00
implementation	internal/lsp: refactor find-implementation handling	2019-12-23 22:59:19 +00:00
importedcomplit
imports	internal/lsp/source: start import diffs at byte 0	2019-11-08 19:30:12 +00:00
index
interfacerank
keywords	internal/lsp: suggest "fallthrough" only inside switches	2019-12-10 22:10:49 +00:00
labels	internal/lsp: fix label completion in range and type switch stmts	2019-10-22 21:33:09 +00:00
links	internal/lsp: create links for golang/go#1234-style strings	2019-12-27 05:39:25 +00:00
maps	internal/lsp: improve completions in *ast.MapType	2019-10-24 19:03:17 +00:00
nested_complit	internal/lsp: improve completion for *ast.ArrayTypes	2019-10-23 16:34:50 +00:00
nodisk	internal/lsp: fix race condition in metadata handling	2019-11-04 20:35:57 +00:00
noparse	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
noparse_format	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
rank	internal/lsp: fix variadic interface completion ranking	2019-11-18 05:14:29 +00:00
references	internal/lsp/source: add support for references in the same workspace	2019-11-14 20:04:27 +00:00
rename	internal/lsp/testadata/rename: add a test case for renames across packages	2019-11-14 22:24:11 +00:00
selector	internal/lsp: sort by label after score	2019-12-30 21:11:21 +00:00
signature	tools/gopls: add cmd support for signature	2019-10-31 22:07:37 +00:00
snippets	internal/lsp/source: fix some invalid literal candidates	2020-01-08 20:36:44 +00:00
suggestedfix
symbols	tools/gopls: add cmd support for symbols	2019-11-01 17:43:07 +00:00
testy	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
typeassert
types
unimported	internal/lsp/source: cap number of unimported completions	2019-12-06 20:21:18 +00:00
unresolved
unsafe
variadic	internal/lsp: fix variadic interface completion ranking	2019-11-18 05:14:29 +00:00
summary.txt.golden	internal/lsp/source: fix some invalid literal candidates	2020-01-08 20:36:44 +00:00