Rebecca Stambler 58eba7e750 internal/lsp: refactor go.mod diagnostics to simplify the API ... Currently, diagnostics for modules that are missing from the go.mod appear in the Go files in which those modules are imported. As a result, the diagnostics were previously calculated as part of the Go file diagnostic calculations. This is convoluted and required passing around an extra map. This CL puts that logic in the ModTidyHandle where it belongs. The diagnostics for the Go files are combined from the multiple sources. Also, added a skipped test for golang/go#39784, since this CL was originally intended to be a fix for that issue... Change-Id: Ic0f9aa235dcd56ea131a2339de9801346f715415 Reviewed-on: https://go-review.googlesource.com/c/tools/+/242579 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>		2020-07-16 22:50:03 +00:00
..
codelens_test.go	internal/lsp: don't use -modfile for go mod commands	2020-06-22 20:30:43 +00:00
definition_test.go	internal/lsp/regtest: put testing.T back in the test func signature	2020-04-14 18:42:46 +00:00
diagnostics_test.go	internal/lsp: don't keep track of closed overlays	2020-07-16 17:49:00 +00:00
doc.go	internal/lsp/regtest: add expository package documentation	2020-04-28 21:10:48 +00:00
env_test.go	internal/lsp: instrument work done reporting to use in regtests	2020-04-28 20:46:32 +00:00
env.go	internal/lsp/regtest: add regression tests for on-disk file changes	2020-07-01 22:06:37 +00:00
formatting_test.go	gopls, internal/lsp: support an extra formatting hook for gofumpt	2020-07-13 21:42:47 +00:00
generate_test.go	internal/lsp/regtest: add support for testing generate commands	2020-05-04 19:25:30 +00:00
imports_test.go	internal/lsp/regtest: remove stray short timeout	2020-07-08 18:38:56 +00:00
link_test.go	internal/lsp: honor GOPRIVATE in documentLinks and go.mod hovers	2020-06-18 13:42:42 +00:00
modfile_test.go	internal/lsp: refactor go.mod diagnostics to simplify the API	2020-07-16 22:50:03 +00:00
reg_test.go	internal/lsp/regtest: simpler way to invert options	2020-07-16 18:20:50 +00:00
runner.go	internal/lsp/lsprpc: improvements to daemon logging	2020-07-16 19:33:22 +00:00
shared_test.go	internal/lsp: support configurable codeLens	2020-05-08 18:47:35 +00:00
symbol_helper_test.go	internal/lsp/fake: define Symbol method on Editor	2020-05-11 20:27:07 +00:00
symbol_test.go	internal/lsp/source: add a new symbolStyle configuration option	2020-06-26 17:13:37 +00:00
unix_test.go	internal/lsp/regtest: add a t.Skip for golang/go#36824 regtest	2020-05-21 15:57:04 +00:00
vendor_test.go	internal/lsp: support go mod vendor as a command	2020-06-04 18:33:45 +00:00
watch_test.go	internal/lsp/regtest: await IWL before running tests	2020-07-08 00:37:08 +00:00
wrappers.go	internal/lsp/regtest: add regression tests for on-disk file changes	2020-07-01 22:06:37 +00:00