mirror of
https://github.com/golang/go
synced 2024-11-27 03:31:29 -07:00
35693d037f
When inlining a function call expression, it's possible that the function callee subexpression has side effects that need to be preserved. This used to not be an issue, because inlining wouldn't recognize these as inlinable anyway. But golang.org/cl/266199 extended the inlining logic to recognize more cases, but did not notice that the actual inlining code was discarding side effects. Issue identified by danscales@. Fixes #42703. Change-Id: I95f8fc076b6ca4e9362e80ec26dad9d87a5bc44a Reviewed-on: https://go-review.googlesource.com/c/go/+/271219 Reviewed-by: Dan Scales <danscales@google.com> Trust: Dan Scales <danscales@google.com> Trust: Matthew Dempsky <mdempsky@google.com>
20 lines
340 B
Go
20 lines
340 B
Go
// run
|
|
|
|
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
var ok [2]bool
|
|
|
|
func main() {
|
|
f()()
|
|
if !ok[0] || !ok[1] {
|
|
panic("FAIL")
|
|
}
|
|
}
|
|
|
|
func f() func() { ok[0] = true; return g }
|
|
func g() { ok[1] = true }
|