1
0
mirror of https://github.com/golang/go synced 2024-11-18 14:54:40 -07:00
go/gopls/integration/govim
Rob Findley 9a0fabac01 internal/lsp: fix errors found by staticcheck
While experimenting with different static analysis on x/tools, I noticed
that there are many actionable diagnostics found by staticcheck. Fix the
ones that were not false positives.

Change-Id: I0b68cf1f636b57b557db879fad84fff9b7237a89
Reviewed-on: https://go-review.googlesource.com/c/tools/+/222248
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-03-19 19:20:54 +00:00
..
artifacts.go internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
cloudbuild.harness.yaml gopls/integration/govim: switch to latest, and improve artifacts 2020-02-05 14:18:39 +00:00
cloudbuild.yaml gopls/integration/govim: update to go1.14 images 2020-03-09 17:26:05 +00:00
Dockerfile gopls/integration/govim: update to go1.14 images 2020-03-09 17:26:05 +00:00
README.md gopls/integration/govim: switch to latest, and improve artifacts 2020-02-05 14:18:39 +00:00
run_local.sh gopls/integration/govim: update build steps to capture artifacts 2020-01-15 14:49:07 +00:00
run_tests_for_cloudbuild.sh gopls/integration/govim: switch to latest, and improve artifacts 2020-02-05 14:18:39 +00:00

govim integration tests

Files in this directory configure Cloud Build to run govim integration tests against a gopls binary built from source.

Running on GCP

To run these integration tests in Cloud Build, use the following steps. Here we assume that $PROJECT_ID is a valid GCP project and $BUCKET is a cloud storage bucket owned by that project.

  • cd to the root directory of the tools project.
  • (at least once per GCP project) Build the test harness:
$ gcloud builds submit \
	--project="${PROJECT_ID}" \
	--config=gopls/integration/govim/cloudbuild.harness.yaml \
	--substitutions=_RESULT_BUCKET="${BUCKET}"
  • Run the integration tests:
$ gcloud builds submit \
	--project="${PROJECT_ID}" \
	--config=gopls/integration/govim/cloudbuild.yaml \
	--substitutions=_RESULT_BUCKET="${BUCKET}"

Fetching Artifacts

Assuming the artifacts bucket is world readable, you can fetch integration from GCS. They are located at:

  • logs: https://storage.googleapis.com/${BUCKET}/log-${EVALUATION_ID}.txt
  • artifact tarball: https://storage.googleapis.com/${BUCKET}/govim/${EVALUATION_ID}/artifacts.tar.gz

The artifacts.go command can be used to fetch both artifacts using an evaluation id.

Running locally

Run gopls/integration/govim/run_local.sh. This may take a while the first time it is run, as it will require building the test harness. Currently this script assumes that docker may be executed without sudo.