1
0
mirror of https://github.com/golang/go synced 2024-11-11 20:20:23 -07:00
go/src
Cherry Zhang 98f8454a73 cmd/link: don't decode type symbol in shared library in deadcode
In the linker's deadcode pass we decode type symbols for
interface satisfaction analysis. When linking against Go shared
libraries, the type symbol may come from a shared library, so it
doesn't have data in the current module being linked, so we cannot
decode it. We already have code to skip DYNIMPORT symbols. However,
this doesn't actually work, because at that point the type symbols'
names haven't been mangled, whereas they may be mangled in the
shared library. So the symbol definition (in shared library) and
reference (in current module) haven't been connected.

Skip decoding type symbols of type Sxxx (along with DYNIMPORT)
when linkShared.

Note: we cannot skip all type symbols, as we still need to mark
unexported methods defined in the current module.

Fixes #44031.

Change-Id: I833d19a060c94edbd6fc448172358f9a7d760657
Reviewed-on: https://go-review.googlesource.com/c/go/+/288496
Trust: Cherry Zhang <cherryyz@google.com>
Trust: Than McIntosh <thanm@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
2021-02-02 16:00:58 +00:00
..
archive archive/tar: fix typo in comment 2021-01-08 02:03:24 +00:00
bufio bufio: make string(int) conversion safer 2020-11-28 03:50:50 +00:00
builtin
bytes bytes: add example for (*Buffer).Bytes 2020-11-11 20:51:00 +00:00
cmd cmd/link: don't decode type symbol in shared library in deadcode 2021-02-02 16:00:58 +00:00
compress all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
container
context
crypto crypto/x509: remove leftover CertificateRequest field 2021-01-27 21:04:09 +00:00
database/sql database/sql: fix typo in comment 2020-12-10 18:23:15 +00:00
debug debug/dwarf: don't try to parse addr/rnglists header 2020-12-14 18:06:06 +00:00
embed embed: update docs for proposal tweaks 2021-01-29 19:48:48 +00:00
encoding encoding/asn1: document unmarshaling behavior for IMPLICIT string fields 2021-01-12 18:32:48 +00:00
errors
expvar
flag
fmt
go all: introduce and use internal/execabs 2021-01-21 19:10:18 +00:00
hash all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
html html/template: revert "avoid race when escaping updates template" 2021-01-25 20:41:05 +00:00
image all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
index/suffixarray all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
internal all: introduce and use internal/execabs 2021-01-21 19:10:18 +00:00
io io/ioutil: fix example test for WriteFile to allow it to run in the playground 2021-01-22 23:03:58 +00:00
log all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
math math: fix typo in sqrt.go code comment 2021-01-27 00:15:06 +00:00
mime all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
net net/http/fcgi: remove locking added to prevent a test-only race 2021-01-26 00:02:15 +00:00
os os: further document limitations around naked file descriptors 2021-01-26 00:30:18 +00:00
path all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
plugin
reflect Revert "reflect: support multiple keys in struct tags" 2021-01-07 23:43:25 +00:00
regexp regexp/syntax: add note about Unicode character classes 2020-11-25 15:10:09 +00:00
runtime runtime: document pointer write atomicity for memclrNoHeapPointers 2021-01-29 19:11:07 +00:00
sort all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
strconv all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
strings
sync sync: use 386 instead of x86-32 to refer to the 32 bit x86 architecture 2020-11-23 05:57:35 +00:00
syscall syscall: generate readlen/writelen for openbsd libc 2021-01-28 16:45:43 +00:00
testdata
testing testing/fstest,os: clarify racy behavior of TestFS 2021-01-08 16:34:00 +00:00
text text/template: error on range over send channel 2020-12-15 13:59:00 +00:00
time lib/time, time/tzdata: update tzdata to 2021a 2021-01-25 16:08:46 +00:00
unicode
unsafe
vendor std: update golang.org/x/net to 20201209123823-ac852fbbde11 2020-12-10 18:27:38 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod std: update golang.org/x/net to 20201209123823-ac852fbbde11 2020-12-10 18:27:38 +00:00
go.sum std: update golang.org/x/net to 20201209123823-ac852fbbde11 2020-12-10 18:27:38 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.