1
0
mirror of https://github.com/golang/go synced 2024-11-26 21:51:44 -07:00
go/src
Dmitri Shuralyov 98f3d7fecb all: gofmt more (but vendor, testdata, and top-level test directories)
CL 294430 made packages in std and cmd modules use Go 1.17 gofmt format,
adding //go:build lines. This change applies the same formatting to some
more packages that 'go fmt' missed (e.g., syscall/js, runtime/msan), and
everything else that is easy and safe to modify in bulk.

Consider the top-level test directory, testdata, and vendor directories
out of scope, since there are many files that don't follow strict gofmt
formatting, often for intentional and legitimate reasons (testing gofmt
itself, invalid Go programs that shouldn't crash the compiler, etc.).

That makes it easy and safe to gofmt -w the .go files that are found
with gofmt -l with aforementioned directories filtered out:

	$ gofmt -l . 2>/dev/null | \
		grep -v '^test/' | \
		grep -v '/testdata/' | \
		grep -v '/vendor/' | wc -l
	      51

None of the 51 files are generated. After this change, the same command
prints 0.

For #41184.

Change-Id: Ia96ee2a0f998d6a167d4473bcad17ad09bc1d86e
Reviewed-on: https://go-review.googlesource.com/c/go/+/341009
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
2021-08-13 20:45:17 +00:00
..
archive
bufio
builtin
bytes
cmd all: gofmt more (but vendor, testdata, and top-level test directories) 2021-08-13 20:45:17 +00:00
compress
container
context
crypto all: gofmt 2021-07-31 23:59:40 +00:00
database/sql
debug
embed
encoding
errors
expvar
flag
fmt
go [dev.typeparams] all: merge master (46fd547) into dev.typeparams 2021-08-12 12:43:12 -07:00
hash
html
image image/gif: fix typo in the comment (io.ReadByte -> io.ByteReader) 2021-06-30 17:58:50 +00:00
index/suffixarray
internal all: gofmt more (but vendor, testdata, and top-level test directories) 2021-08-13 20:45:17 +00:00
io io/fs: don't use absolute path in DirEntry.Name doc 2021-08-02 17:18:57 +00:00
log
math math/big: fix typo of comment (BytesScanner to ByteScanner) 2021-06-29 16:57:13 +00:00
mime
net net/http: speed up and deflake TestCancelRequestWhenSharingConnection 2021-08-04 15:26:45 +00:00
os os/exec: re-enable LookPathTest/16 2021-08-12 15:58:41 +00:00
path path/filepath: deflake TestEvalSymlinksAboveRoot on darwin 2021-06-30 20:03:34 +00:00
plugin
reflect [dev.typeparams] all: merge master (798ec73) into dev.typeparams 2021-07-22 12:50:31 -07:00
regexp
runtime all: gofmt more (but vendor, testdata, and top-level test directories) 2021-08-13 20:45:17 +00:00
sort
strconv
strings
sync
syscall all: gofmt more (but vendor, testdata, and top-level test directories) 2021-08-13 20:45:17 +00:00
testdata
testing testing: clarify T.Name returns a distinct name of the running test 2021-07-27 05:07:46 +00:00
text text/scanner: use Go convention in Position doc comment 2021-07-18 21:00:03 +00:00
time time: fix docs for new comma layouts 2021-08-12 21:29:44 +00:00
unicode
unsafe spec, unsafe: clarify unsafe.Slice docs 2021-07-02 19:26:52 +00:00
vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod [dev.typeparams] src,cmd: bump go.mod to 'go 1.18' 2021-07-02 23:55:07 +00:00
go.sum [dev.typeparams] src,cmd: run 'go mod tidy' 2021-07-03 17:45:01 +00:00
make.bash src/make.*: make --no-clean flag a no-op that prints a warning 2021-08-11 22:07:50 +00:00
make.bat src/make.*: make --no-clean flag a no-op that prints a warning 2021-08-11 22:07:50 +00:00
Make.dist
make.rc src/make.*: make --no-clean flag a no-op that prints a warning 2021-08-11 22:07:50 +00:00
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.