1
0
mirror of https://github.com/golang/go synced 2024-11-18 10:14:45 -07:00
go/src
Than McIntosh 9861e8b2fd cmd/{cover,go}: avoid use of os.PathListSeparator in cmd/cover flag
Rework the mechanism for passing a list of output files from cmd/go to
cmd/cover when running new-style package-scope coverage
instrumentation (-pkgcfg mode). The old scheme passed a single string
with all output files joined together with os.PathListSeparator, but
this scheme is not viable on plan9, where strings containing the
separator character are not permitted when running exec.Command().
Instead, switch cmd/cover to use an arguments file (a file containing
a list of names) to specify names of instrumented output files. This
fixes the cmd/cover test failures on the plan9 builders.

Updates #51430.

Change-Id: I919f5e0a79500e28648fb9177225a9b938e4fdee
Reviewed-on: https://go-review.googlesource.com/c/go/+/436675
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
2022-09-29 14:51:21 +00:00
..
archive
bufio bufio: use bytes.Clone 2022-09-27 19:42:34 +00:00
builtin
bytes bytes,strings: optimize Repeat 2022-09-27 16:55:15 +00:00
cmd cmd/{cover,go}: avoid use of os.PathListSeparator in cmd/cover flag 2022-09-29 14:51:21 +00:00
compress compress/flate: update NewReader documentation 2022-09-15 20:02:32 +00:00
container
context
crypto crypto: use fmt.Appendf 2022-09-29 09:14:45 +00:00
database/sql database: use bytes.Clone 2022-09-28 03:16:54 +00:00
debug debug/elf: return error on reading from SHT_NOBITS sections 2022-09-27 22:16:32 +00:00
embed
encoding encoding/gob: add top level security doc 2022-09-29 00:30:21 +00:00
errors
expvar
flag flag: test IsBoolFlag when creating the usage message 2022-09-19 21:54:35 +00:00
fmt fmt: rely on utf8.AppendRune 2022-09-21 13:54:31 +00:00
go go/types, types2: more concise error messages for cycle errors 2022-09-29 14:21:33 +00:00
hash hash/crc32: remove redundant code 2022-09-15 21:07:21 +00:00
html
image image/gif,image/jpeg,image/png: skip FuzzDecode in testing short mode 2022-09-27 15:57:34 +00:00
index/suffixarray
internal go/types, types2: more concise error messages for cycle errors 2022-09-29 14:21:33 +00:00
io
log
math math: show value of integer constants in comments 2022-09-21 14:07:39 +00:00
mime mime/multipart: use %w when wrapping error in NextPart 2022-09-20 02:11:38 +00:00
net all: fix some typos 2022-09-28 15:13:20 +00:00
os os/exec: refactor goroutine error reporting 2022-09-29 02:34:30 +00:00
path path/filepath: optimize isReservedName 2022-09-23 04:34:52 +00:00
plugin
reflect reflect: clarify that Value.Comparable checks the value 2022-09-27 16:24:53 +00:00
regexp
runtime runtime/coverage: apis to emit counter data under user control 2022-09-29 14:14:24 +00:00
sort
strconv strconv: add a test case when base is illegal 2022-09-15 21:09:39 +00:00
strings bytes,strings: optimize Repeat 2022-09-27 16:55:15 +00:00
sync sync: clarify Cond.Wait documentation 2022-09-26 21:58:42 +00:00
syscall syscall: check if to is nil to prevent panic from WSASendto 2022-09-26 20:42:40 +00:00
testdata
testing runtime/coverage: improve unit tests 2022-09-29 14:13:26 +00:00
text text/template/parse: fix confusion about markers near right delims 2022-09-23 15:03:43 +00:00
time time: add comment explaining >>33 in Now 2022-09-28 09:05:54 +00:00
unicode
unsafe
vendor all: update vendored golang.org/x/net 2022-09-21 15:07:53 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored golang.org/x/net 2022-09-21 15:07:53 +00:00
go.sum all: tidy std module 2022-09-21 20:59:10 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.