mirror of
https://github.com/golang/go
synced 2024-11-18 12:14:42 -07:00
f7a8a58e8d
Add some basic tests for diagnostics using the new go/packages/packagestest framework. Change-Id: I6a7bfba6c392928a9eb123ab71ceb73785c12600 Reviewed-on: https://go-review.googlesource.com/c/145697 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
90 lines
2.1 KiB
Go
90 lines
2.1 KiB
Go
package lsp
|
|
|
|
import (
|
|
"go/token"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"golang.org/x/tools/go/packages"
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
)
|
|
|
|
func (v *view) diagnostics(uri protocol.DocumentURI) (map[string][]protocol.Diagnostic, error) {
|
|
pkg, err := v.typeCheck(uri)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
reports := make(map[string][]protocol.Diagnostic)
|
|
for _, filename := range pkg.GoFiles {
|
|
reports[filename] = []protocol.Diagnostic{}
|
|
}
|
|
var parseErrors, typeErrors []packages.Error
|
|
for _, err := range pkg.Errors {
|
|
switch err.Kind {
|
|
case packages.ParseError:
|
|
parseErrors = append(parseErrors, err)
|
|
case packages.TypeError:
|
|
typeErrors = append(typeErrors, err)
|
|
default:
|
|
// ignore other types of errors
|
|
continue
|
|
}
|
|
}
|
|
// Don't report type errors if there are parse errors.
|
|
errors := typeErrors
|
|
if len(parseErrors) > 0 {
|
|
errors = parseErrors
|
|
}
|
|
for _, err := range errors {
|
|
pos := parseErrorPos(err)
|
|
line := float64(pos.Line) - 1
|
|
col := float64(pos.Column) - 1
|
|
diagnostic := protocol.Diagnostic{
|
|
// TODO(rstambler): Add support for diagnostic ranges.
|
|
Range: protocol.Range{
|
|
Start: protocol.Position{
|
|
Line: line,
|
|
Character: col,
|
|
},
|
|
End: protocol.Position{
|
|
Line: line,
|
|
Character: col,
|
|
},
|
|
},
|
|
Severity: protocol.SeverityError,
|
|
Source: "LSP: Go compiler",
|
|
Message: err.Msg,
|
|
}
|
|
if _, ok := reports[pos.Filename]; ok {
|
|
reports[pos.Filename] = append(reports[pos.Filename], diagnostic)
|
|
}
|
|
}
|
|
return reports, nil
|
|
}
|
|
|
|
func parseErrorPos(pkgErr packages.Error) (pos token.Position) {
|
|
remainder1, first, hasLine := chop(pkgErr.Pos)
|
|
remainder2, second, hasColumn := chop(remainder1)
|
|
if hasLine && hasColumn {
|
|
pos.Filename = remainder2
|
|
pos.Line = second
|
|
pos.Column = first
|
|
} else if hasLine {
|
|
pos.Filename = remainder1
|
|
pos.Line = first
|
|
}
|
|
return pos
|
|
}
|
|
|
|
func chop(text string) (remainder string, value int, ok bool) {
|
|
i := strings.LastIndex(text, ":")
|
|
if i < 0 {
|
|
return text, 0, false
|
|
}
|
|
v, err := strconv.ParseInt(text[i+1:], 10, 64)
|
|
if err != nil {
|
|
return text, 0, false
|
|
}
|
|
return text[:i], int(v), true
|
|
}
|