Heschi Kreinick 9611592c72 internal/lsp/cache: fix load race, refactor ... As far as I can tell, the code I removed in from load did roughly nothing -- returning nil metadata didn't suppress type checking as I think was intended. Throwing away the metadata also created the race in Pull the check for missing import changes up to PackageHandles, where it is non-racy and can cause type checking to be skipped. Simplify and refactor. Fixes golang/go#35951. Change-Id: Id4b32b86569afb36863aaf982616b2b3727b0e83 Reviewed-on: https://go-review.googlesource.com/c/tools/+/209737 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>		2019-12-04 01:13:08 +00:00
..
analysis.go	internal/lsp: rename CheckPackageHandle to PackageHandle	2019-12-02 18:29:46 +00:00
builtin.go	internal/lsp: rename Files to CompiledGoFiles	2019-11-20 22:19:51 +00:00
cache.go	internal/lsp: use options hooks to install diff driver	2019-10-11 16:38:31 +00:00
check.go	internal/lsp: suppress all errors when a view is loaded and checked	2019-12-02 18:41:08 +00:00
error_test.go	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
errors.go	internal/lsp: use version numbers in diagnostic messages	2019-11-21 20:01:42 +00:00
external.go	internal/lsp: use versioned URIs in rename and code actions	2019-11-13 05:52:40 +00:00
file.go	internal/lsp: modify approach to watching changed files	2019-10-22 21:33:45 +00:00
load.go	internal/lsp/cache: fix load race, refactor	2019-12-04 01:13:08 +00:00
parse.go	internal/lsp: improve completion after accidental keywords	2019-12-03 04:30:02 +00:00
pkg.go	internal/lsp: set version correctly after textDocument/didOpen	2019-11-25 19:35:51 +00:00
session.go	internal/lsp: suppress all errors when a view is loaded and checked	2019-12-02 18:41:08 +00:00
snapshot.go	internal/lsp/cache: fix load race, refactor	2019-12-04 01:13:08 +00:00
view.go	internal/lsp: track and parse non-compiled go files	2019-11-25 19:20:50 +00:00
watcher.go	internal/lsp/cache: add finer-grained control of file changes	2019-11-14 16:11:15 +00:00