mirror of
https://github.com/golang/go
synced 2024-11-18 11:34:45 -07:00
90a8482a17
I made the default be that, where there are differences between types2 and -G=0 error messages, we want errorcheck tests to pass types2. Typically, we can get errorcheck to pass on types2 and -G=0 if they give the same number of error messages on the same lines, just different wording. If they give a different number of error messages, then I made types2 pass. I added an exception list for -G=0 to cover those cases where -G=0 and types give different numbers of error messages. Because types2 does not run if there are syntax errors, for several tests, I had to split the tests into two parts in order to get all the indicated errors to be reported in types2 (bug228.go, bug388.go, issue11610.go, issue14520.go) I tried to preserve the GCCGO labeling correctly (but may have gotten some wrong). When types2 now matches where a GCCGO error previously occurred, I transformed GCCGO_ERROR -> ERROR. When types2 no longer reports an error in a certain place, I transformed ERROR -> GCCGO_ERROR. When types2 reports an error in a new place, I used GC_ERROR. The remaining entries in types2Failures are things that I think we probably still need to fix - either actually missing errors in types2, or cases where types2 gives worse errors than -G=0. Change-Id: I7f01e82b322b16094096b67d7ed2bb39b410c34f Reviewed-on: https://go-review.googlesource.com/c/go/+/372854 Trust: Dan Scales <danscales@google.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
40 lines
1.4 KiB
Go
40 lines
1.4 KiB
Go
// errorcheck
|
|
|
|
// Copyright 2017 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Verify that invalid imports are rejected by the compiler.
|
|
// Does not compile.
|
|
|
|
package main
|
|
|
|
// Each of these pairs tests both `` vs "" strings
|
|
// and also use of invalid characters spelled out as
|
|
// escape sequences and written directly.
|
|
// For example `"\x00"` tests import "\x00"
|
|
// while "`\x00`" tests import `<actual-NUL-byte>`.
|
|
import "" // ERROR "import path"
|
|
import `` // ERROR "import path"
|
|
import "\x00" // ERROR "import path"
|
|
import `\x00` // ERROR "import path"
|
|
import "\x7f" // ERROR "import path"
|
|
import `\x7f` // ERROR "import path"
|
|
import "a!" // ERROR "import path"
|
|
import `a!` // ERROR "import path"
|
|
import "a b" // ERROR "import path"
|
|
import `a b` // ERROR "import path"
|
|
import "a\\b" // ERROR "import path"
|
|
import `a\\b` // ERROR "import path"
|
|
import "\"`a`\"" // ERROR "import path"
|
|
import `\"a\"` // ERROR "import path"
|
|
import "\x80\x80" // ERROR "import path"
|
|
import `\x80\x80` // ERROR "import path"
|
|
import "\xFFFD" // ERROR "import path"
|
|
import `\xFFFD` // ERROR "import path"
|
|
|
|
// Invalid local imports.
|
|
// types2 adds extra "not used" error.
|
|
import "/foo" // ERROR "import path cannot be absolute path|not used"
|
|
import "c:/foo" // ERROR "import path contains invalid character|invalid character"
|