94a948d1b1
Currently trace.lock is reentrant in a few cases. AFAICT, this was necessary a long time ago when the trace reader would goparkunlock, and might flush a trace buffer while parking the goroutine. Today, that's no longer true, since that always happens without the trace.lock held. However, traceReadCPU does still rely on this behavior, since it could get called either with trace.lock held, or without it held. The silver lining here is that it doesn't *need* trace.lock to be held, so the trace reader can just drop the lock to call traceReadCPU (this is probably also nice for letting other goroutines flush while the trace reader is reading from the CPU log). Stress-tested with $ stress ./trace.test -test.run="TestTraceCPUProfile|TestTraceStress|TestTraceStressStartStop" ... 42m0s: 24520 runs so far, 0 failures Change-Id: I2016292c17fe7384050fcc0c446f5797c4e46437 Reviewed-on: https://go-review.googlesource.com/c/go/+/496296 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Michael Knyszek <mknyszek@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.