1
0
mirror of https://github.com/golang/go synced 2024-11-12 08:40:21 -07:00
go/doc
Brad Fitzpatrick 9296d4efe7 net/http: don't retry Transport requests if they have a body
This rolls back https://golang.org/cl/27117 partly, softening it so it
only retries POST/PUT/DELETE etc requests where there's no Body (nil
or NoBody). This is a little useless, since most idempotent requests
have a body (except maybe DELETE), but it's late in the Go 1.8 release
cycle and I want to do the proper fix.

The proper fix will look like what we did for http2 and only retrying
the request if Request.GetBody is defined, and then creating a new request
for the next attempt. See https://golang.org/cl/33971 for the http2 fix.

Updates #15723
Fixes #18239
Updates #18241

Change-Id: I6ebaa1fd9b19b5ccb23c8d9e7b3b236e71cf57f3
Reviewed-on: https://go-review.googlesource.com/34134
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Tom Bergan <tombergan@google.com>
2016-12-08 21:08:00 +00:00
..
articles doc, cmd/go: adjust documentation for default GOPATH 2016-11-30 21:40:00 +00:00
codewalk all: make copyright headers consistent with one space after period 2016-05-02 13:43:18 +00:00
devel doc: document go1.7.4 and go1.6.4 2016-12-01 20:17:21 +00:00
gopher website: recreate 16px and 32px favicon 2016-08-25 15:43:32 +00:00
play doc/play: update URL for concurrent pi 2016-01-06 20:23:21 +00:00
progs all: spell "marshal" and "unmarshal" consistently 2016-11-12 00:13:35 +00:00
asm.html doc: add s390x information to asm.html 2016-07-26 00:18:42 +00:00
cmd.html doc: fix broken link to the vet command documentation 2016-05-16 21:30:31 +00:00
code.html doc, cmd/go: adjust documentation for default GOPATH 2016-11-30 21:40:00 +00:00
conduct.html doc: s/race/ethnicity/ in the Code of Conduct 2016-10-27 02:56:06 +00:00
contrib.html doc: add 1.7 to golang.org/project 2016-08-16 01:04:17 +00:00
contribute.html doc: add notes on good commit messages 2016-05-24 19:23:18 +00:00
debugging_with_gdb.html doc: fix source link in gdb docs 2016-01-06 21:58:19 +00:00
docs.html doc: update go tour installation instructions 2016-08-31 18:54:04 +00:00
effective_go.html doc/effectivego: reword confusing sentence 2016-10-26 16:09:54 +00:00
gccgo_contribute.html doc: fix stale gofrontend/gccgo contribution link 2016-09-01 18:38:38 +00:00
gccgo_install.html all: link to https instead of http 2015-07-11 14:36:33 +00:00
go1.1.html all: fix misprints in comments 2015-06-11 14:18:57 +00:00
go1.2.html doc: drop scheme from links that are known to support HTTPS 2014-07-25 10:28:39 +10:00
go1.3.html [release-branch.go1.4] doc: scrub references to code.google.com 2014-12-12 14:00:48 +11:00
go1.4.html doc/go1.4.html: fix typo 2015-03-24 18:17:49 +00:00
go1.5.html doc: mention that go install removes binaries built by go build 2015-09-08 18:46:07 +00:00
go1.6.html doc: GCC 6 will have the Go 1.6.1 user libraries 2016-04-14 20:00:33 +00:00
go1.7.html doc: fix broken links in 1.7 release docs 2016-11-07 18:51:29 +00:00
go1.8.html net/http: don't retry Transport requests if they have a body 2016-12-08 21:08:00 +00:00
go1.8.txt doc: remove two go1.8.txt items 2016-11-30 04:15:45 +00:00
go1.html doc: link directly to https://golang.org/dl/ 2014-09-12 09:15:58 +10:00
go1compat.html doc: add a clause about embedded methods to go1compat 2015-07-22 01:25:32 +00:00
go_faq.html doc, cmd/go: adjust documentation for default GOPATH 2016-11-30 21:40:00 +00:00
go_mem.html doc/go_mem.html: correct the channel example 2015-03-16 21:43:31 +00:00
go_spec.html spec: add subtitles to section on "for" statements 2016-11-18 20:26:11 +00:00
go-logo-black.png doc: pngcrush and remove old, unused images 2012-03-08 14:18:28 +11:00
go-logo-blue.png doc: pngcrush and remove old, unused images 2012-03-08 14:18:28 +11:00
go-logo-white.png doc: pngcrush and remove old, unused images 2012-03-08 14:18:28 +11:00
help.html doc: revise help page with categories and more links 2016-01-14 03:15:39 +00:00
ie.css
install-source.html doc: document the mips port in install-source.html 2016-12-06 04:23:46 +00:00
install.html doc: mention more binary download architectures 2016-12-06 22:33:48 +00:00
root.html doc: only show Share button when enabled 2015-09-02 05:58:52 +00:00
security.html doc: security fixes are prepared for two most recent stable releases 2016-03-09 03:32:23 +00:00
share.png godoc: change link styles, add 'pop out' button 2012-03-13 11:00:11 +11:00
tos.html doc: drop scheme from links that are known to support HTTPS 2014-07-25 10:28:39 +10:00