1
0
mirror of https://github.com/golang/go synced 2024-10-01 03:28:32 -06:00
go/internal/lsp/cache
Muir Manders 912f50adde internal/lsp: don't invalidate dependents' metadata
When a file is changed, we invalidate various cached data so we
re-type check and refetch metadata as needed. Previously when a file
changed we would delete the metadata for all transitive reverse
dependencies. This broke all-packages-in-workspace features since we
could no longer fetch the package handle for packages without
metadata.

Fix by only deleting metadata for the packages that the file being
changed belongs to. It doesn't seem like a package's metadata contains
anything that is sensitive to changes in the package's dependencies.

Change-Id: I6a2d5df49ecd4d627b37689e48ed48fe78ce658d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/210458
Run-TryBot: Muir Manders <muir@mnd.rs>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-11 18:25:29 +00:00
..
analysis.go internal/lsp: propagate and handle context cancellation errors 2019-12-05 22:50:56 +00:00
builtin.go internal/lsp: rename Files to CompiledGoFiles 2019-11-20 22:19:51 +00:00
cache.go internal/lsp: use options hooks to install diff driver 2019-10-11 16:38:31 +00:00
check.go internal/lsp: add error handling for self imports 2019-12-06 19:13:54 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: add error handling for self imports 2019-12-06 19:13:54 +00:00
external.go internal/lsp: use versioned URIs in rename and code actions 2019-11-13 05:52:40 +00:00
file.go internal/lsp: modify approach to watching changed files 2019-10-22 21:33:45 +00:00
load.go internal/lsp/cache: clean up dead code after CL 209737 2019-12-05 21:55:04 +00:00
parse.go internal/lsp: fix AST bookkeeping as we repair nodes 2019-12-05 06:08:18 +00:00
pkg.go internal/lsp: set version correctly after textDocument/didOpen 2019-11-25 19:35:51 +00:00
session.go internal/lsp: fix error suppression in (*session).createView 2019-12-06 20:33:56 +00:00
snapshot.go internal/lsp: don't invalidate dependents' metadata 2019-12-11 18:25:29 +00:00
view.go internal/lsp: track and parse non-compiled go files 2019-11-25 19:20:50 +00:00
watcher.go internal/lsp/cache: add finer-grained control of file changes 2019-11-14 16:11:15 +00:00