mirror of
https://github.com/golang/go
synced 2024-11-06 01:46:12 -07:00
771c57e68e
We need to be careful that when doing value graph surgery, we not
re-substitute a value that has already been substituted. That can lead
to confusing a previous iteration's value with the current iteration's
value.
The simple fix in this CL just aborts the optimization if it detects
intertwined phis (a phi which is the argument to another phi). It
might be possible to keep the optimization with a more complicated
CL, but:
1) This CL is clearly safe to backport.
2) There were no instances of this abort triggering in
all.bash, prior to the test introduced in this CL.
Fixes #45175
Change-Id: I2411dca03948653c053291f6829a76bec0c32330
Reviewed-on: https://go-review.googlesource.com/c/go/+/304251
Trust: Keith Randall <khr@golang.org>
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
30 lines
386 B
Go
30 lines
386 B
Go
// run
|
|
|
|
// Copyright 2021 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
//go:noinline
|
|
func f(c bool) int {
|
|
b := true
|
|
x := 0
|
|
y := 1
|
|
for b {
|
|
b = false
|
|
y = x
|
|
x = 2
|
|
if c {
|
|
return 3
|
|
}
|
|
}
|
|
return y
|
|
}
|
|
|
|
func main() {
|
|
if got := f(false); got != 0 {
|
|
panic(got)
|
|
}
|
|
}
|