1
0
mirror of https://github.com/golang/go synced 2024-11-18 18:54:42 -07:00
go/internal/lsp
Muir Manders 825cb06263 internal/lsp: downrank "nil" completion candidate
Having nil ranked normally causes it to show up as the top candidate
in cases like:

context.WithCancel(<>) // "nil" shows up before "context.Background()"

"context.Background()" gets a slight score penalty since it is a deep
completion, so "nil" is ranked highest.

Sometimes you do want "nil", but it's such a short identifier you
probably aren't leaning too heavily on autocompletion. I think it
makes sense to optimize for the case when you want something non-nil.

Change-Id: I537927db2b573535e751380c4cba5c9873dfe524
Reviewed-on: https://go-review.googlesource.com/c/tools/+/210539
Run-TryBot: Muir Manders <muir@mnd.rs>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-12 05:12:00 +00:00
..
browser
cache internal/lsp: move DidModifyFile into internal/lsp/cache 2019-12-12 03:49:59 +00:00
cmd internal/lsp: make Text in DidSave request a pointer 2019-12-10 19:28:57 +00:00
debug internal/lsp: fix the debug info pages 2019-11-04 23:16:26 +00:00
diff internal/lsp: fix unified diffs of edits at the end of a file 2019-10-11 16:38:14 +00:00
fuzzy internal/lsp: fix fuzzy matcher inconsistency 2019-10-22 21:05:28 +00:00
protocol internal/lsp: Make Text in DidSave at *string rather than a string 2019-12-10 20:07:04 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp: downrank "nil" completion candidate 2019-12-12 05:12:00 +00:00
telemetry internal/lsp: call load in (*session).NewView 2019-11-07 23:34:59 +00:00
testdata internal/lsp: downrank "nil" completion candidate 2019-12-12 05:12:00 +00:00
tests internal/lsp: don't resend diagnostics if they are unchanged 2019-12-12 04:27:51 +00:00
code_action.go internal/lsp: rename CheckPackageHandle to PackageHandle 2019-12-02 18:29:46 +00:00
command.go internal/lsp: fix panic in bestView 2019-11-16 21:44:31 +00:00
completion_test.go internal/lsp: fix variadic interface completion ranking 2019-11-18 05:14:29 +00:00
completion.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
definition.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
diagnostics.go internal/lsp: don't resend diagnostics if they are unchanged 2019-12-12 04:27:51 +00:00
folding_range.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
format.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
general.go internal/lsp: return snapshot when creating a view 2019-12-05 13:33:17 +00:00
highlight.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
hover.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
implementation.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
link.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
lsp_test.go internal/lsp: don't resend diagnostics if they are unchanged 2019-12-12 04:27:51 +00:00
references.go internal/lsp: fix find-references to search from all package variants 2019-12-11 23:36:49 +00:00
rename.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server.go internal/lsp: don't resend diagnostics if they are unchanged 2019-12-12 04:27:51 +00:00
signature_help.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
symbols.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
text_synchronization.go internal/lsp: move DidModifyFile into internal/lsp/cache 2019-12-12 03:49:59 +00:00
watched_files.go internal/lsp: move DidModifyFile into internal/lsp/cache 2019-12-12 03:49:59 +00:00
workspace.go internal/lsp: return snapshot when creating a view 2019-12-05 13:33:17 +00:00