1
0
mirror of https://github.com/golang/go synced 2024-11-23 06:50:05 -07:00
go/src
Dan Scales 8eeb1bff1d cmd/compile: reuse same node for global dictionaries
Change stencil.go:getDictionaryValue() and reflect.go:getDictionary() to
reuse any existing name node that has been created for the needed global
dictionary. Otherwise, these functions may set the Def on a specific
dictionary sym to two different name nodes, which means the first node
will not satisfy the invariant 'n.Sym().Def.(*ir.Name) == n' (which is
the assertion in this issue).

Fixes #47896

Change-Id: I1e7ae1efd077a83c7878b4342feb6d28d52476cc
Reviewed-on: https://go-review.googlesource.com/c/go/+/344609
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Trust: Dan Scales <danscales@google.com>
2021-08-24 00:01:29 +00:00
..
archive archive/zip: prevent preallocation check from overflowing 2021-08-20 16:49:35 +00:00
bufio
builtin
bytes
cmd cmd/compile: reuse same node for global dictionaries 2021-08-24 00:01:29 +00:00
compress
container
context
crypto crypto/rand, internal/syscall/unix: don't use getentropy on iOS 2021-08-20 16:44:10 +00:00
database/sql
debug
embed
encoding
errors
expvar
flag
fmt
go go/types: use TypeList in the Inferred struct 2021-08-23 13:09:18 +00:00
hash
html
image
index/suffixarray
internal all: replace runtime SSE2 detection with GO386 setting 2021-08-23 21:22:58 +00:00
io io: unexport internal methods 2021-08-19 09:11:02 +00:00
log
math math/big: clarified doc string for SetMantExp 2021-08-22 21:43:43 +00:00
mime
net net/http: fix typo in header.go 2021-08-20 18:55:57 +00:00
os os/user: simplify test skip for plan9 2021-08-22 22:04:02 +00:00
path path/filepath: change IsAbs to treat \\host\share as an absolute path 2021-08-18 08:26:44 +00:00
plugin
reflect reflect: fix memmove for big endian cases with new ABI 2021-08-23 15:27:42 +00:00
regexp
runtime all: replace runtime SSE2 detection with GO386 setting 2021-08-23 21:22:58 +00:00
sort
strconv strconv: reject surrogate halves in Unquote 2021-08-21 18:23:58 +00:00
strings strings: smarter growth of temporal buffer and avoid copying on return 2021-08-22 23:49:55 +00:00
sync sync/atomic: fix documentation for CompareAndSwap 2021-08-14 16:56:14 +00:00
syscall syscall: add SyscallN 2021-08-19 17:30:19 +00:00
testdata
testing testing/fstest: allow specifying file for "." in MapFS 2021-08-16 22:27:47 +00:00
text
time time: update current time comment 2021-08-16 17:24:37 +00:00
unicode
unsafe
vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod
go.sum
make.bash
make.bat
Make.dist
make.rc
race.bash src: simplify race.bash checking condition 2021-08-17 01:49:12 +00:00
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.