mirror of
https://github.com/golang/go
synced 2024-09-29 04:14:27 -06:00
ca5f65d771
For base generic type that is written to export file, we need to mark all of its methods, include exported+unexported methods, as reachable, so they can be available for instantiation if necessary. But markType only looks for exported methods, thus causing the crash in #49143. To fix this, we introduce new method p.markGeneric, to mark all methods of the base generic type. This issue has happend for a while (maybe since we add generic import/export during go1.18 cycle), and was un-intentionally "fixed" in CL 356254, when we agresssively call p.markEmbed(t). CL 357232 fixed that wrong agressive behavior, thus reproduce the bug on tip. Fixes #49143 Change-Id: Ie64574a05fffb282e9dcc8739df4378c5b6b0468 Reviewed-on: https://go-review.googlesource.com/c/go/+/358814 Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com> Trust: Dan Scales <danscales@google.com> Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Dan Scales <danscales@google.com>
25 lines
451 B
Go
25 lines
451 B
Go
// Copyright 2021 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package a
|
|
|
|
import "sync"
|
|
|
|
type Loader[K comparable, R any] struct {
|
|
batch *LoaderBatch[K, R]
|
|
}
|
|
|
|
func (l *Loader[K, R]) Load() error {
|
|
l.batch.f()
|
|
return nil
|
|
}
|
|
|
|
type LoaderBatch[K comparable, R any] struct {
|
|
once *sync.Once
|
|
}
|
|
|
|
func (b *LoaderBatch[K, R]) f() {
|
|
b.once.Do(func() {})
|
|
}
|