1
0
mirror of https://github.com/golang/go synced 2024-09-24 11:10:12 -06:00
go/test/fixedbugs/issue8139.go
Russ Cox d646040fd1 runtime: fix 1-byte return during x.(T) for 0-byte T
The 1-byte write was silently clearing a byte on the stack.
If there was another function call with more arguments
in the same stack frame, no harm done.
Otherwise, if the variable at that location was already zero,
no harm done.
Otherwise, problems.

Fixes #8139.

LGTM=dsymonds
R=golang-codereviews, dsymonds
CC=golang-codereviews, iant, r
https://golang.org/cl/100940043
2014-06-02 21:06:30 -04:00

51 lines
801 B
Go

// run
// Copyright 2014 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Issue 8139. The x.(T) assertions used to write 1 (unexpected)
// return byte for the 0-byte return value T.
package main
import "fmt"
type T struct{}
func (T) M() {}
type M interface {
M()
}
var e interface{} = T{}
var i M = T{}
var b bool
func f1() int {
if b {
return f1() // convince inliner not to inline
}
z := 0x11223344
_ = e.(T)
return z
}
func f2() int {
if b {
return f1() // convince inliner not to inline
}
z := 0x11223344
_ = i.(T)
return z
}
func main() {
x := f1()
y := f2()
if x != 0x11223344 || y != 0x11223344 {
fmt.Printf("BUG: x=%#x y=%#x, want 0x11223344 for both\n", x, y)
}
}