1
0
mirror of https://github.com/golang/go synced 2024-09-29 19:24:33 -06:00
go/src
qiulaidongfeng 8c45dddd5d reflect: delete TODO pass safe to packEface don't need to copy if safe==true
valueInterface not copy result in the follow incorrect behavior
w1.  x := ValueOf(&v).Elem()
r1.  iface := Value.Interface()
w2.  x.Set() or x.SetT()

The write operation of W2 will be observed by the read operation of r1,
but the existing behavior is not.

The valueInterface in deepValueEqual can, in theory, pass safe==true to not copy the object,
but there is no benchmark to indicate that the memory allocation has changed,
maybe we don't actually need safe==true here.

Change-Id: I55c423fd50adac8822a7fdbfe67af89ee223eace
GitHub-Last-Rev: 4a63867098
GitHub-Pull-Request: golang/go#64618
Reviewed-on: https://go-review.googlesource.com/c/go/+/548436
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Auto-Submit: Keith Randall <khr@golang.org>
2024-01-23 17:19:58 +00:00
..
archive
arena
bufio
builtin builtin: mention PanicNilError in comments of recover 2023-12-18 19:42:41 +00:00
bytes
cmd cmd/cgo/internal/test: skip TestCallbackCallersSEH when internal linking 2024-01-23 06:52:00 +00:00
cmp cmp: add test case for uinitptr 2024-01-17 17:58:34 +00:00
compress
container
context
crypto crypto/sha512: provide optimised assembly for riscv64 2024-01-22 23:53:04 +00:00
database/sql
debug all: replace outdated links 2023-12-30 00:24:56 +00:00
embed
encoding
errors
expvar
flag
fmt fmt: don't pad strings with zeros 2024-01-23 08:29:53 +00:00
go go/types, types2: typeparams.IndexExpr must not be an ast.Expr 2024-01-22 16:17:05 +00:00
hash hash/crc32: fix codegen to align with manual changes 2024-01-23 00:03:20 +00:00
html
image
index/suffixarray
internal runtime,internal/poll: move websocket handling out of the runtime on Windows 2024-01-23 15:36:19 +00:00
io io/fs: godoc links to testing/fstest 2024-01-15 21:21:41 +00:00
iter
log log/slog: clarify SetDefault behavior 2024-01-08 18:26:18 +00:00
maps
math math/big: fix uint64 overflow in nat.mulRange 2024-01-09 15:29:36 +00:00
mime
net net: report timeouts more aggressively in Accept in the fake implementation 2024-01-23 17:05:09 +00:00
os os: relax tests and add examples for UserCacheDir and UserConfigDir 2024-01-10 17:35:49 +00:00
path io/fs,path/filepath: fix typo in SkipAll/SkipDir doc 2024-01-09 08:50:19 +00:00
plugin
reflect reflect: delete TODO pass safe to packEface don't need to copy if safe==true 2024-01-23 17:19:58 +00:00
regexp
runtime runtime,internal/poll: move websocket handling out of the runtime on Windows 2024-01-23 15:36:19 +00:00
slices slices: explicitly discard results of some functions 2024-01-05 21:35:07 +00:00
sort
strconv
strings
sync sync: use map[any]any instead of map[interface{}]interface{} in the godoc 2024-01-08 17:02:01 +00:00
syscall
testdata
testing
text
time time: add a regression test for time.AfterFunc goroutine starvation 2024-01-22 16:16:08 +00:00
unicode
unsafe
vendor all: update vendored dependencies 2024-01-22 19:00:13 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored dependencies 2024-01-22 19:00:13 +00:00
go.sum all: update vendored dependencies 2024-01-22 19:00:13 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.