mirror of
https://github.com/golang/go
synced 2024-11-18 16:44:43 -07:00
ee45598d2f
For clarity and performance reasons, we want the fast path of goimports to be purely syntactic. Packages whose import paths don't match their package names make this harder. Before this CL, we parsed each imported package to get its real package name. Now, we make named imports for such packages, and on subsequent runs we don't have to do the extra work. A package name matches its import path if the name is the last segment of the path, or the next-to-last before a version suffix vNN. gopkg.in style .vNN suffixes are considered mismatching. The previous attempt (CL 145699) failed because I assumed we'd be able to find all packages from scratch. That's not true if the import path is completely unrelated to the package name. To avoid that problem, rather than removing and re-adding mismatched imports, we just literally add names to them. Fixes golang/go#28428 Change-Id: I93bd820f5956162ae9c99afa73bdcfc570a2e7b4 Reviewed-on: https://go-review.googlesource.com/c/152000 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> |
||
|---|---|---|
| .. | ||
| fix_test.go | ||
| fix.go | ||
| imports.go | ||
| mkindex.go | ||
| mkstdlib.go | ||
| sortimports.go | ||
| zstdlib.go | ||