1
0
mirror of https://github.com/golang/go synced 2024-11-14 08:40:27 -07:00
go/src/cmd/trace
Austin Clements a1eec645e1 cmd/trace: don't shift trace slices to 0
Currently all trace slices get shifted to start at time 0. This makes
it very difficult to find specific points in time unless they fall in
the first slice.

For example, right now when you click "View trace
(6.005646218s-8.155419698s)" on the trace tool's main page, the trace
view puts the first event in that slice at time 0. If you're looking
for something that happened at time 7s, you have to look at time
0.9943537s in the trace view. And if you want to subtract times taken
from different slices, you have to figure out what those time really
correspond to.

Fix this by telling the trace viewer not to shift the times when it
imports the trace. In the above example, this makes the view of that
second trace slice start at time 6.005646218s, so you don't have to do
any gymnastics to find or calculate times in later slices.

Change-Id: I04e0afda60f5573fdd8ad96238c24013297ef263
Reviewed-on: https://go-review.googlesource.com/54633
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2017-08-11 17:53:17 +00:00
..
doc.go cmd/trace: document that trace viewer is only tested on chromium 2017-04-20 16:44:55 +00:00
goroutines.go cmd/trace: move goroutine analysis code to internal/trace 2015-03-11 12:53:24 +00:00
main.go cmd/trace: document that trace viewer is only tested on chromium 2017-04-20 16:44:55 +00:00
pprof.go runtime/pprof/internal/profile: move internal/pprof/profile here 2017-02-24 20:45:21 +00:00
trace_test.go cmd/trace: Record mark assists in execution traces 2017-02-10 18:03:42 +00:00
trace.go cmd/trace: don't shift trace slices to 0 2017-08-11 17:53:17 +00:00