1
0
mirror of https://github.com/golang/go synced 2024-10-01 11:28:34 -06:00
go/src
Keith Randall 8a317ebc0f cmd/compile: don't eliminate all registers when restricting to desired ones
We shouldn't mask to desired registers if we haven't masked out all the
forbidden registers yet.  In this path we haven't masked out the nospill
registers yet. If the resulting mask contains only nospill registers, then
allocReg fails.

This can only happen on resultNotInArgs-marked instructions, which exist
only on the ARM64, MIPS, MIPS64, and PPC64 ports.

Maybe there's a better way to handle resultNotInArgs instructions.
But for 1.13, this is a low-risk fix.

Fixes #33355

Change-Id: I1082f78f798d1371bde65c58cc265540480e4fa4
Reviewed-on: https://go-review.googlesource.com/c/go/+/188178
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
2019-08-01 02:15:18 +00:00
..
archive all: shorten some tests 2019-05-22 12:54:00 +00:00
bufio bufio: fix ExampleScanner_Bytes comment, add error check 2019-06-25 00:29:24 +00:00
builtin
bytes bytes: remove obsolete comment 2019-05-28 02:52:39 +00:00
cmd cmd/compile: don't eliminate all registers when restricting to desired ones 2019-08-01 02:15:18 +00:00
compress compress/gzip: add missing error check in test 2019-05-24 14:55:39 +00:00
container all: shorten some tests 2019-05-22 12:54:00 +00:00
context context: document CancelFunc to be safe for simultaneous use by multiple goroutines 2019-05-20 16:08:56 +00:00
crypto crypto/x509: add Ed25519 to ExampleParsePKIXPublicKey 2019-07-29 16:52:01 +00:00
database/sql database/sql: add support for decimal interface 2019-06-13 16:59:01 +00:00
debug debug/elf: add version information to all dynamic symbols 2019-07-05 18:18:26 +00:00
encoding encoding/json: clarify Marshal behavior for string keys of maps 2019-07-31 21:49:08 +00:00
errors errors: clarify doc for As 2019-06-11 21:50:05 +00:00
expvar all: change some function documentation to be more idiomatic 2019-07-28 18:09:57 +00:00
flag
fmt fmt: fix typo in errors.go 2019-06-27 04:16:38 +00:00
go all: change some function documentation to be more idiomatic 2019-07-28 18:09:57 +00:00
hash
html html/template, text/template: document glob semantics 2019-06-17 21:53:49 +00:00
image image/draw: change argument type to be consistent with other args 2019-05-24 15:22:14 +00:00
index/suffixarray index/suffixarray: index 3-10X faster in half the memory 2019-05-13 18:50:32 +00:00
internal cmd/go: add go command known variables to test cache hash 2019-07-15 16:28:58 +00:00
io
log
math cmd/gofmt: fix normalization of imaginary number literals 2019-06-21 17:24:29 +00:00
mime mime: encode CTL and non-US-ASCII characters in FormatMediaType 2019-05-23 15:45:00 +00:00
net net/http: return nil from Header.Clone if the receiver is nil 2019-07-31 16:15:56 +00:00
os os: document File's concurrent operation resource limits 2019-07-23 23:42:43 +00:00
path
plugin
reflect reflect,doc: use "the" instead of "a" in IsZero docs 2019-06-18 15:08:08 +00:00
regexp regexp/syntax: exclude full range from String negation case 2019-05-22 04:43:25 +00:00
runtime runtime: call sysHugePage less often 2019-07-30 18:53:01 +00:00
sort sort: simplify bootstrap 2019-05-02 20:30:31 +00:00
strconv strconv: document handling of NaN and ±Inf 2019-05-31 11:26:23 +00:00
strings strings: clarify usage of Title and ToTitle 2019-07-30 02:52:57 +00:00
sync sync: document implementation of Once.Do 2019-07-01 14:45:49 +00:00
syscall Revert "syscall: use Ctty before fd shuffle" 2019-06-27 16:53:02 +00:00
testdata
testing Revert "cmd/go: move automatic testing.Init call into generated test code" 2019-07-22 21:42:51 +00:00
text text/scanner: remove AllowDigitSeparator flag again 2019-06-27 21:13:53 +00:00
time time: clarify when draining a Timer's channel is needed 2019-07-18 20:43:28 +00:00
unicode all: update to Unicode 11 2019-04-25 20:33:22 +00:00
unsafe
vendor vendor: go get -u golang.org/x/crypto && go mod vendor 2019-06-13 17:44:27 +00:00
all.bash
all.bat
all.rc
bootstrap.bash bootstrap.bash: preserve file times when copying 2019-04-27 14:36:00 +00:00
buildall.bash cmd/go: run full 'go vet' during 'go test' for packages in GOROOT 2019-05-16 03:24:56 +00:00
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod vendor: go get -u golang.org/x/crypto && go mod vendor 2019-06-13 17:44:27 +00:00
go.sum vendor: go get -u golang.org/x/crypto && go mod vendor 2019-06-13 17:44:27 +00:00
iostest.bash
make.bash
make.bat
Make.dist
make.rc
naclmake.bash
nacltest.bash
race.bash
race.bat
README.vendor all: document vendoring in the standard library 2019-05-09 17:11:16 +00:00
run.bash cmd/dist: allow builders to control granularity of test/ directory sharding 2019-05-06 23:02:29 +00:00
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -m golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not just
the target module.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.