mirror of
https://github.com/golang/go
synced 2024-11-17 09:04:44 -07:00
4c943abb95
Fixes for #49680, #49695, #45867, and #49370 all assumed that SetGCPercent(-1) doesn't block until the GC's mark phase is done, but it actually does. The cause of 3 of those 4 failures comes from the fact that at the beginning of the sweep phase, the GC does try to preempt every P once, and this may run concurrently with test code. In the fourth case, the issue was likely that only *one* of the debug_test.go tests was missing a call to SetGCPercent(-1). Just to be safe, leave a TODO there for now to remove the extraneous runtime.GC calls, but leave the calls in. Updates #49680, #49695, #45867, and #49370. Change-Id: Ibf4e64addfba18312526968bcf40f1f5d54eb3f1 Reviewed-on: https://go-review.googlesource.com/c/go/+/369815 Reviewed-by: Austin Clements <austin@google.com> Trust: Michael Knyszek <mknyszek@google.com> Run-TryBot: Michael Knyszek <mknyszek@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> |
||
---|---|---|
.. | ||
testdata | ||
backdoor.go | ||
buildid_linux.go | ||
callback_c_gc.c | ||
callback_c_gccgo.c | ||
callback_c.c | ||
callback.go | ||
cgo_linux_test.go | ||
cgo_stubs_android_test.go | ||
cgo_test.go | ||
cgo_thread_lock.go | ||
cgo_unix_test.go | ||
cthread_unix.c | ||
cthread_windows.c | ||
issue1435.go | ||
issue4029.c | ||
issue4029.go | ||
issue4029w.go | ||
issue4273.c | ||
issue4273b.c | ||
issue4339.c | ||
issue4339.h | ||
issue5548_c.c | ||
issue5740a.c | ||
issue5740b.c | ||
issue6833_c.c | ||
issue6907export_c.c | ||
issue6997_linux.c | ||
issue6997_linux.go | ||
issue7234_test.go | ||
issue8148.c | ||
issue8148.go | ||
issue8331.h | ||
issue8517_windows.c | ||
issue8517_windows.go | ||
issue8517.go | ||
issue8694.go | ||
issue8811.c | ||
issue18146.go | ||
issue20910.c | ||
issue21897.go | ||
issue21897b.go | ||
issue31891.c | ||
issue42018_windows.go | ||
issue42018.go | ||
issue42495.go | ||
overlaydir_test.go | ||
pkg_test.go | ||
setgid_linux.go | ||
sigaltstack.go | ||
sigprocmask.c | ||
sigprocmask.go | ||
test_unix.go | ||
test_windows.go | ||
test.go | ||
testx.c | ||
testx.go | ||
typeparam.go |