mirror of
https://github.com/golang/go
synced 2024-11-18 08:14:41 -07:00
606019cb4b
This information is redundant with the position information already
provided. Also, no other -m diagnostics print out function name.
While here, report parameter leak diagnostics against the parameter
declaration position rather than the function, and use Warnl for
"moved to heap" messages.
Test cases updated programmatically by removing the first word from
every "no match for" error emitted by run.go:
go run run.go |& \
sed -E -n 's/^(.*):(.*): no match for `([^ ]* (.*))` in:$/\1!\2!\3!\4/p' | \
while IFS='!' read -r fn line before after; do
before=$(echo "$before" | sed 's/[.[\*^$()+?{|]/\\&/g')
after=$(echo "$after" | sed -E 's/(\&|\\)/\\&/g')
fn=$(find . -name "${fn}" | head -1)
sed -i -E -e "${line}s/\"${before}\"/\"${after}\"/" "${fn}"
done
Passes toolstash-check.
Change-Id: I6e02486b1409e4a8dbb2b9b816d22095835426b5
Reviewed-on: https://go-review.googlesource.com/c/go/+/195040
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
55 lines
1.3 KiB
Go
55 lines
1.3 KiB
Go
// errorcheck -0 -m -l
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test escape analysis for function parameters.
|
|
|
|
// In this test almost everything is BAD except the simplest cases
|
|
// where input directly flows to output.
|
|
|
|
package foo
|
|
|
|
func f(buf []byte) []byte { // ERROR "leaking param: buf to result ~r1 level=0$"
|
|
return buf
|
|
}
|
|
|
|
func g(*byte) string
|
|
|
|
func h(e int) {
|
|
var x [32]byte // ERROR "moved to heap: x$"
|
|
g(&f(x[:])[0])
|
|
}
|
|
|
|
type Node struct {
|
|
s string
|
|
left, right *Node
|
|
}
|
|
|
|
func walk(np **Node) int { // ERROR "leaking param content: np"
|
|
n := *np
|
|
w := len(n.s)
|
|
if n == nil {
|
|
return 0
|
|
}
|
|
wl := walk(&n.left)
|
|
wr := walk(&n.right)
|
|
if wl < wr {
|
|
n.left, n.right = n.right, n.left // ERROR "ignoring self-assignment"
|
|
wl, wr = wr, wl
|
|
}
|
|
*np = n
|
|
return w + wl + wr
|
|
}
|
|
|
|
// Test for bug where func var f used prototype's escape analysis results.
|
|
func prototype(xyz []string) {} // ERROR "xyz does not escape"
|
|
func bar() {
|
|
var got [][]string
|
|
f := prototype
|
|
f = func(ss []string) { got = append(got, ss) } // ERROR "leaking param: ss" "func literal does not escape"
|
|
s := "string"
|
|
f([]string{s}) // ERROR "\[\]string literal escapes to heap"
|
|
}
|