1
0
mirror of https://github.com/golang/go synced 2024-11-05 15:16:11 -07:00
go/internal/lsp/regtest/env_test.go
Rob Findley 30a0893a98 internal/lsp: use the token supplied by the client for progress
Our WorkDone reporting was generating a random token for each unit of
work, even if a token was supplied by the client.  Change this to use
the client token if it is non-empty, and skip the
workDoneProgress/create request.

After this change we can no longer rely on tokens being a string.
Update our progress tracking accordingly.

For golang/go#40527

Change-Id: I702f739c466efb613b69303aaf07005addd3b5e2
Reviewed-on: https://go-review.googlesource.com/c/tools/+/247321
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-08-10 15:15:12 +00:00

68 lines
1.8 KiB
Go

// Copyright 2020 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package regtest
import (
"context"
"encoding/json"
"testing"
"golang.org/x/tools/internal/lsp/protocol"
)
func TestProgressUpdating(t *testing.T) {
e := &Env{
state: State{
outstandingWork: make(map[protocol.ProgressToken]*workProgress),
completedWork: make(map[string]int),
},
}
ctx := context.Background()
if err := e.onWorkDoneProgressCreate(ctx, &protocol.WorkDoneProgressCreateParams{
Token: "foo",
}); err != nil {
t.Fatal(err)
}
if err := e.onWorkDoneProgressCreate(ctx, &protocol.WorkDoneProgressCreateParams{
Token: "bar",
}); err != nil {
t.Fatal(err)
}
updates := []struct {
token string
value interface{}
}{
{"foo", protocol.WorkDoneProgressBegin{Kind: "begin", Title: "foo work"}},
{"bar", protocol.WorkDoneProgressBegin{Kind: "begin", Title: "bar work"}},
{"foo", protocol.WorkDoneProgressEnd{Kind: "end"}},
{"bar", protocol.WorkDoneProgressReport{Kind: "report", Percentage: 42}},
}
for _, update := range updates {
params := &protocol.ProgressParams{
Token: update.token,
Value: update.value,
}
data, err := json.Marshal(params)
if err != nil {
t.Fatal(err)
}
var unmarshaled protocol.ProgressParams
if err := json.Unmarshal(data, &unmarshaled); err != nil {
t.Fatal(err)
}
if err := e.onProgress(ctx, &unmarshaled); err != nil {
t.Fatal(err)
}
}
if _, ok := e.state.outstandingWork["foo"]; ok {
t.Error("got work entry for \"foo\", want none")
}
got := *e.state.outstandingWork["bar"]
want := workProgress{title: "bar work", percent: 42}
if got != want {
t.Errorf("work progress for \"bar\": %v, want %v", got, want)
}
}