1
0
mirror of https://github.com/golang/go synced 2024-11-19 14:24:47 -07:00
go/src
Josh Bleecher Snyder 87412a1430 text/tabwriter: fix BenchmarkPyramid and BenchmarkRagged
These were added in CL 106979. They were wrong.

The correct impact of CL 106979 on these benchmarks is:

name            old time/op    new time/op    delta
Pyramid/10-8      6.22µs ± 1%    5.68µs ± 0%    -8.78%  (p=0.000 n=15+13)
Pyramid/100-8      275µs ± 1%     255µs ± 1%    -7.30%  (p=0.000 n=15+13)
Pyramid/1000-8    25.6ms ± 1%    24.8ms ± 1%    -2.88%  (p=0.000 n=15+14)
Ragged/10-8       8.98µs ± 1%    6.74µs ± 0%   -24.98%  (p=0.000 n=15+14)
Ragged/100-8      85.3µs ± 0%    57.5µs ± 1%   -32.51%  (p=0.000 n=13+15)
Ragged/1000-8      847µs ± 1%     561µs ± 1%   -33.85%  (p=0.000 n=14+15)

name            old alloc/op   new alloc/op   delta
Pyramid/10-8      4.74kB ± 0%    4.88kB ± 0%    +3.04%  (p=0.000 n=15+15)
Pyramid/100-8      379kB ± 0%     411kB ± 0%    +8.50%  (p=0.000 n=15+12)
Pyramid/1000-8    35.3MB ± 0%    41.6MB ± 0%   +17.68%  (p=0.000 n=15+15)
Ragged/10-8       4.82kB ± 0%    1.82kB ± 0%   -62.13%  (p=0.000 n=15+15)
Ragged/100-8      45.4kB ± 0%     1.8kB ± 0%   -95.98%  (p=0.000 n=15+15)
Ragged/1000-8      449kB ± 0%       2kB ± 0%   -99.59%  (p=0.000 n=15+15)

name            old allocs/op  new allocs/op  delta
Pyramid/10-8        50.0 ± 0%      35.0 ± 0%   -30.00%  (p=0.000 n=15+15)
Pyramid/100-8        704 ± 0%       231 ± 0%   -67.19%  (p=0.000 n=15+15)
Pyramid/1000-8     10.0k ± 0%      2.1k ± 0%   -79.52%  (p=0.000 n=15+15)
Ragged/10-8         60.0 ± 0%      19.0 ± 0%   -68.33%  (p=0.000 n=15+15)
Ragged/100-8         511 ± 0%        19 ± 0%   -96.28%  (p=0.000 n=15+15)
Ragged/1000-8      5.01k ± 0%     0.02k ± 0%   -99.62%  (p=0.000 n=15+15)


This is an improvement over what was originally reported,
except the increase in alloc/op for the Pyramid benchmarks.

Change-Id: Ib2617c1288ce35f2c78e0172533d231b86e48bc2
Reviewed-on: https://go-review.googlesource.com/111643
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2018-05-06 04:27:05 +00:00
..
archive archive/zip: avoid data descriptor when writing directories 2018-05-02 23:34:50 +00:00
bufio bufio: document ReadFrom/WriteTo calls to underlying methods 2018-03-28 22:21:52 +00:00
builtin
bytes bytes, strings: improve EqualFold fast version for ASCII 2018-05-01 18:52:19 +00:00
cmd cmd/go: don't give an error for an attempt to recreate a symlink 2018-05-05 00:54:52 +00:00
compress compress/gzip: skip builder-only test on iOS 2018-05-04 14:46:19 +00:00
container container/heap: fix comments style 2018-04-11 20:11:09 +00:00
context context: avoid defer in the cancelCtx.Err method 2018-04-15 21:35:53 +00:00
crypto crypto/rand, crypto/x509: add js/wasm architecture 2018-05-03 18:00:24 +00:00
database/sql database/sql: make error prefixes consistent 2018-05-05 16:27:20 +00:00
debug all: skip unsupported tests for js/wasm 2018-04-30 19:39:18 +00:00
encoding all: skip unsupported tests for js/wasm 2018-04-30 19:39:18 +00:00
errors
expvar all: use strings.Builder instead of bytes.Buffer where appropriate 2018-03-26 23:05:53 +00:00
flag flag: correct zero values when printing defaults 2018-04-01 20:17:22 +00:00
fmt fmt: make %v doc for compound objects consistent 2018-04-17 23:47:44 +00:00
go cmd/go, go/build: add support for gccgo tooldir 2018-05-04 00:46:12 +00:00
hash
html text/template: copy Decl field when copying PipeNode 2018-04-10 14:26:58 +00:00
image
index/suffixarray
internal internal/cpu: remove platform specific prefix from cpu hwcap variables 2018-05-01 15:50:19 +00:00
io io/ioutil: change TempFile prefix to a pattern 2018-04-12 20:00:25 +00:00
log all: skip unsupported tests for js/wasm 2018-04-30 19:39:18 +00:00
math math/bits: move tests into their own package 2018-05-01 15:33:01 +00:00
mime mime: add wasm architecture 2018-04-13 20:20:12 +00:00
net net/http: ignore case of basic auth scheme in Request.BasicAuth 2018-05-04 18:40:56 +00:00
os os: remove superfluous comments 2018-05-02 14:41:57 +00:00
path path/filepath: fix Win32 tests missing 'chcp' 2018-04-26 18:25:15 +00:00
plugin
reflect reflect: define MyBuffer more locally in TestImplicitMapConversion 2018-04-18 12:47:39 +00:00
regexp regexp: use sync.Pool to cache regexp.machine objects 2018-04-03 16:03:19 +00:00
runtime runtime: ignore sigaction error on Linux if it is for SIGRTMAX 2018-05-04 18:46:33 +00:00
sort sort: fix typo in comment 2018-04-22 22:32:11 +00:00
strconv strconv: simplify and optimize Itoa(small) 2018-05-03 18:07:02 +00:00
strings strings: fix encoding of \u0080 in map 2018-05-04 05:37:45 +00:00
sync sync/atomic: redirect many functions to runtime/internal/atomic 2018-05-03 21:35:01 +00:00
syscall syscall/js: add package 2018-05-03 18:00:07 +00:00
testing testing: fix racey access to t.failed 2018-05-02 17:51:26 +00:00
text text/tabwriter: fix BenchmarkPyramid and BenchmarkRagged 2018-05-06 04:27:05 +00:00
time cmd/vet: better align print warnings with fmt 2018-05-04 02:57:37 +00:00
unicode
unsafe
vendor/golang_org/x vendor: update golang.org/x/net/internal/nettest from upstream 2018-05-04 17:34:07 +00:00
all.bash
all.bat
all.rc
androidtest.bash
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
iostest.bash
make.bash src/*.bash: remove some trailing whitespace 2018-05-04 14:47:49 +00:00
make.bat
Make.dist
make.rc
naclmake.bash
nacltest.bash
race.bash src/*.bash: remove some trailing whitespace 2018-05-04 14:47:49 +00:00
race.bat
run.bash src/run.bash: remove some trailing whitespace 2018-04-01 16:12:47 +00:00
run.bat
run.rc