1
0
mirror of https://github.com/golang/go synced 2024-11-17 05:54:46 -07:00
go/src
Robert Griesemer 86fa2551fb cmd/compile/internal/types2: permit parentheses around types in interfaces
Before Go 1.18, an embedded type name in an interface could not be
parenthesized. With generalized embedding of types in interfaces,
where one might write ~(chan<- int) for clarity (making clear that
the ~ applies to the entire channel type), it also makes sense to
permit (chan<- int), or (int) for that matter.

Adjust the parser accordingly to match the spec.

(go/types already accepts the notation as specified by the spec.)

Fixes #52391.

Change-Id: Ifdd9a199c5ccc3473b2dac40dbca31d2df10d12b
Reviewed-on: https://go-review.googlesource.com/c/go/+/400797
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
2022-04-19 23:20:11 +00:00
..
archive all: gofmt main repo 2022-04-11 16:34:30 +00:00
bufio
builtin all: gofmt main repo 2022-04-11 16:34:30 +00:00
bytes bytes: explode checks for n too large 2022-04-16 02:01:19 +00:00
cmd cmd/compile/internal/types2: permit parentheses around types in interfaces 2022-04-19 23:20:11 +00:00
compress all: gofmt main repo 2022-04-11 16:34:30 +00:00
container all: gofmt main repo 2022-04-11 16:34:30 +00:00
context all: gofmt main repo 2022-04-11 16:34:30 +00:00
crypto crypto/rand: remove all buffering 2022-04-19 23:03:11 +00:00
database/sql all: gofmt main repo 2022-04-11 16:34:30 +00:00
debug debug/pe: read string table in 10M chunks 2022-04-15 17:17:18 +00:00
embed all: gofmt main repo 2022-04-11 16:34:30 +00:00
encoding encoding/binary: add AppendVarint AppendUvarint 2022-04-15 01:19:37 +00:00
errors
expvar all: gofmt main repo 2022-04-11 16:34:30 +00:00
flag all: gofmt main repo 2022-04-11 16:34:30 +00:00
fmt all: gofmt main repo 2022-04-11 16:34:30 +00:00
go go/doc: fix incorrect identifier parsing in comments 2022-04-16 01:25:04 +00:00
hash all: gofmt main repo 2022-04-11 16:34:30 +00:00
html all: gofmt main repo 2022-04-11 16:34:30 +00:00
image all: gofmt main repo 2022-04-11 16:34:30 +00:00
index/suffixarray all: gofmt main repo 2022-04-11 16:34:30 +00:00
internal internal/bytealg: optimize indexbyte function for ppc64le/power9 2022-04-15 16:05:09 +00:00
io io/ioutil: provide an equivalent for the deprecated ReadDir 2022-04-19 16:19:27 +00:00
log all: gofmt main repo 2022-04-11 16:34:30 +00:00
math math: improve documentation of Copysign 2022-04-14 17:42:53 +00:00
mime mime: ignore non-extension globs2 entries 2022-04-15 17:07:27 +00:00
net net/http: eliminate arbitrary timeouts in TestServerRequestContextCancel_ConnClose 2022-04-18 22:07:54 +00:00
os os: mark Solaris nam/door/port files as irregular 2022-04-12 01:41:47 +00:00
path all: gofmt main repo 2022-04-11 16:34:30 +00:00
plugin
reflect reflect: adjust MapRange allocation test for noopt builder, take 2 2022-04-19 17:53:51 +00:00
regexp all: gofmt main repo 2022-04-11 16:34:30 +00:00
runtime cmd/compile: fix missing source information in ssa view 2022-04-18 18:43:21 +00:00
sort sort: use pdqsort 2022-04-13 20:16:24 +00:00
strconv all: gofmt main repo 2022-04-11 16:34:30 +00:00
strings all: gofmt main repo 2022-04-11 16:34:30 +00:00
sync all: gofmt main repo 2022-04-11 16:34:30 +00:00
syscall syscall: check correct group in Faccessat 2022-04-12 21:12:19 +00:00
testdata
testing all: gofmt main repo 2022-04-11 16:34:30 +00:00
text all: gofmt main repo 2022-04-11 16:34:30 +00:00
time all: gofmt main repo 2022-04-11 16:34:30 +00:00
unicode all: gofmt main repo 2022-04-11 16:34:30 +00:00
unsafe all: gofmt main repo 2022-04-11 16:34:30 +00:00
vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod
go.sum
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.