Muir Manders 86caa796c7 internal/lsp: search candidate type's package for completions ... When our expected type is a named type from another package, we now always search that other package for completion candidates, even if it is not currently imported. Consider the example: -- foo.go -- import "context" func doSomething(ctx context.Context) {} -- bar.go-- doSomething(<>) "bar.go" doesn't import "context" yet, so normally you need to first import "context" through whatever means before you get completion items from "context". Now we notice that the expected type's package hasn't been imported yet and give deep completions from "context". Another use case is with literal completions. Consider: -- foo.go -- import "bytes" func doSomething(buf *bytes.Buffer) {} -- bar.go-- doSomething(<>) Now you will get a literal completion for "&bytes.Buffer{}" in "bar.go" even though it hasn't imported "bytes" yet. I had to pipe the import info around a bunch of places so the import is added automatically for deep completions and literal completions. Change-Id: Ie86af2aa64ee235038957c1eecf042f7ec2b329b Reviewed-on: https://go-review.googlesource.com/c/tools/+/201207 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2019-10-30 06:26:58 +00:00
..
baz.go.in	internal/lsp: search candidate type's package for completions	2019-10-30 06:26:58 +00:00