8689ea6a4a
With the command below, I was able to reproduce failures within the first 50 or so runs: go test -c -o test && stress -p 32 ./test -test.run Script/test_regexp When printing the full failure output, we'd see: BenchmarkX BenchmarkX: x_test.go:13: LOG: X running N=1 BenchmarkX/Y BenchmarkX/Y: x_test.go:15: LOG: Y running N=1 BenchmarkX/Y: x_test.go:15: LOG: Y running N=100 BenchmarkX/Y: x_test.go:15: LOG: Y running N=10000 BenchmarkX/Y: x_test.go:15: LOG: Y running N=1000000 BenchmarkX/Y: x_test.go:15: LOG: Y running N=100000000 BenchmarkX/Y: x_test.go:15: LOG: Y running N=1000000000 BenchmarkX/Y 1000000000 0.000050 ns/op BenchmarkX/Y: x_test.go:15: LOG: Y running N=1 BenchmarkX/Y: x_test.go:15: LOG: Y running N=30 BenchmarkX/Y: x_test.go:15: LOG: Y running N=1207 BenchmarkX/Y: x_test.go:15: LOG: Y running N=120700 BenchmarkX/Y: x_test.go:15: LOG: Y running N=12070000 BenchmarkX/Y: x_test.go:15: LOG: Y running N=1000000000 BenchmarkX/Y 1000000000 0.000715 ns/op In other words, the N values aren't required to be exact. It seems like they are cut short if the machine is under stress. That's the exact scenario we reproduce above, since I used -p=32 on my laptop with only 4 real CPU cores. First, don't require each line to be present. Instead, use patterns that span multiple lines, so that we can just match the first and last N= lines. Second, don't require the last N= lines to be exact; simply require them to have a reasonably large number of digits. Fixes #36664. Change-Id: I7a9818f1a07099fa6482a26da2ac5cbea0f8ab30 Reviewed-on: https://go-review.googlesource.com/c/go/+/215578 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| favicon.ico | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| robots.txt | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.