qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 20:54:40 -07:00
Code Releases Activity
84cebe1034
go/internal/lsp
History
Michael Matloob 84cebe1034 go/packages: fix incorrect needtypes and needsrcs logic 
This logic is really fiddly and I'm not really 100% sure it's right, though
I've thought about it for quite abit (and added comments to help me reason
through it).

Also always request CompiledGoFiles when NeedTypes is true because we might
need to fall back to loading from source when type data is incorrect.

Fixes golang/go#36441
Fixes golang/go#36547

Change-Id: I1cc27ca2e4401a9abc8502990b0da7d0480f6f84
Reviewed-on: https://go-review.googlesource.com/c/tools/+/214943
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-16 22:59:55 +00:00
..
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache go/packages: internally expose ForTests in go/packages 2020-01-16 22:11:50 +00:00
cmd internal/lsp: diagnose the snapshot on every text synchronization event 2020-01-15 23:07:48 +00:00
debug internal/lsp: add server instance to debug info 2020-01-15 14:58:21 +00:00
diff internal/lsp: fix unified diffs of edits at the end of a file 2019-10-11 16:38:14 +00:00
fuzzy internal/lsp: make golint happy 2019-12-23 18:17:04 +00:00
mod go/packages: fix incorrect needtypes and needsrcs logic 2020-01-16 22:59:55 +00:00
protocol internal/lsp/protocol: support nonstandard requests 2020-01-14 21:52:24 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp/source: return obj decl first in find-references 2020-01-16 16:57:51 +00:00
telemetry internal/lsp: load metadata for a single package ID, when needed 2019-12-30 21:09:35 +00:00
testdata internal/lsp/source: improve completion for "range" and "<-" 2020-01-16 06:24:25 +00:00
tests internal/lsp: show dependency quick fixes for go.mod diagnostics 2020-01-15 16:51:05 +00:00
code_action.go internal/lsp: show dependency quick fixes for go.mod diagnostics 2020-01-15 16:51:05 +00:00
command.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
completion_test.go internal/lsp: merge completion options into source.Options 2020-01-13 20:09:44 +00:00
completion.go internal/lsp/source: improve completion in type assertions 2020-01-16 01:06:23 +00:00
definition.go internal/lsp: finish renaming CheckPackageHandle to PackageHandle 2020-01-14 23:56:10 +00:00
diagnostics.go internal/lsp: don't log context.Cancelation in diagnostics 2020-01-16 18:16:51 +00:00
folding_range.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
format.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
general.go internal/lsp: diagnose the snapshot on every text synchronization event 2020-01-15 23:07:48 +00:00
highlight.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
hover.go internal/lsp: finish renaming CheckPackageHandle to PackageHandle 2020-01-14 23:56:10 +00:00
implementation.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
link.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
lsp_test.go internal/lsp: diagnose the snapshot on every text synchronization event 2020-01-15 23:07:48 +00:00
references.go internal/lsp: refactor find-references and rename 2020-01-16 06:24:15 +00:00
rename.go internal/lsp: refactor find-references and rename 2020-01-16 06:24:15 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server.go internal/lsp: diagnose the snapshot on every text synchronization event 2020-01-15 23:07:48 +00:00
signature_help.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
symbols.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
text_synchronization.go internal/lsp: diagnose the snapshot on every text synchronization event 2020-01-15 23:07:48 +00:00
workspace.go internal/lsp: diagnose the snapshot on every text synchronization event 2020-01-15 23:07:48 +00:00