qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 17:44:47 -07:00
Code Releases Activity
8463f397d0
go/internal/lsp/source
History
Muir Manders 8463f397d0 internal/lsp/source: fix false positive "..." in completions 
In cases like:

    var v interface{}
    fmt.Println(<>)

Completing to "v" would insert "v..." instead of "v". This was due to
a mixup where we were checking if the variadic type "[]interface{}"
was assignable to the candidate type "interface{}" instead of the
other way around.

Fixes golang/go#38652.

Change-Id: I27c0b50bbf4b895924c8ed2c0c9dd6785e98cbe1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/229921
Run-TryBot: Muir Manders <muir@mnd.rs>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-04-25 04:34:58 +00:00
..
code_lens.go x/tools/gopls: run go generate through CodeLens 2020-03-17 04:34:34 +00:00
comment_test.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
comment.go internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
completion_builtin.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
completion_format.go internal/lsp: correctly handle type aliases when formatting 2020-04-23 20:53:58 +00:00
completion_keywords.go internal/lsp/source: offer loop keyword completions in range stmt 2020-03-12 04:57:24 +00:00
completion_labels.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
completion_literal.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
completion_snippet.go internal/lsp: merge completion options into source.Options 2020-01-13 20:09:44 +00:00
completion_statements.go internal/lsp/source: offer completion "if err != nil { return err }" 2020-03-10 21:06:53 +00:00
completion.go internal/lsp/source: fix false positive "..." in completions 2020-04-25 04:34:58 +00:00
deep_completion.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
diagnostics.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
folding_range.go internal/lsp/cache: add file contents to ParseGoHandle 2020-02-13 05:05:14 +00:00
format_test.go internal/lsp/source: trim file very carefully 2020-01-17 20:34:13 +00:00
format.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
highlight.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
hover.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
identifier.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
implementation.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
options.go internal/lsp/source: add option for verbose work progress reporting 2020-04-24 19:57:22 +00:00
references.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
rename_check.go internal/lsp/source: remove unused parameters from functions 2020-03-27 18:57:18 +00:00
rename.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
signature_help.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
source_test.go internal/lsp: fix imports issue with duplicate package decl 2020-04-16 06:17:24 +00:00
symbols.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
types_format.go internal/lsp: correctly handle type aliases when formatting 2020-04-23 20:53:58 +00:00
util.go internal/lsp: refactor code for formatting signatures 2020-04-22 20:52:58 +00:00
view.go internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
workspace_symbol.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00