1
0
mirror of https://github.com/golang/go synced 2024-11-25 16:17:56 -07:00
go/test/fixedbugs/issue30116u.go
Keith Randall 2c423f063b cmd/compile,runtime: provide index information on bounds check failure
A few examples (for accessing a slice of length 3):

   s[-1]    runtime error: index out of range [-1]
   s[3]     runtime error: index out of range [3] with length 3
   s[-1:0]  runtime error: slice bounds out of range [-1:]
   s[3:0]   runtime error: slice bounds out of range [3:0]
   s[3:-1]  runtime error: slice bounds out of range [:-1]
   s[3:4]   runtime error: slice bounds out of range [:4] with capacity 3
   s[0:3:4] runtime error: slice bounds out of range [::4] with capacity 3

Note that in cases where there are multiple things wrong with the
indexes (e.g. s[3:-1]), we report one of those errors kind of
arbitrarily, currently the rightmost one.

An exhaustive set of examples is in issue30116[u].out in the CL.

The message text has the same prefix as the old message text. That
leads to slightly awkward phrasing but hopefully minimizes the chance
that code depending on the error text will break.

Increases the size of the go binary by 0.5% (amd64). The panic functions
take arguments in registers in order to keep the size of the compiled code
as small as possible.

Fixes #30116

Change-Id: Idb99a827b7888822ca34c240eca87b7e44a04fdd
Reviewed-on: https://go-review.googlesource.com/c/go/+/161477
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
2019-03-18 17:33:38 +00:00

113 lines
2.2 KiB
Go

// run
// Copyright 2019 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// This test makes sure the text output for bounds check failures is as expected.
package main
import (
"fmt"
"os"
"runtime"
"text/tabwriter"
)
// Testing with length 3 slices, arrays, and strings.
// A large (>1<<32) value is included to test 32-bit platforms.
var indexes = []uint64{0, 2, 3, 1<<32 - 1, 1<<64 - 1}
var slices = []uint64{0, 3, 4, 1<<32 - 1, 1<<64 - 1}
var w *tabwriter.Writer
func main() {
w = tabwriter.NewWriter(os.Stdout, 0, 0, 1, ' ', tabwriter.AlignRight)
defer w.Flush()
doIndex()
doSlice()
doSlice3()
}
func doIndex() {
a := []int{1, 2, 3}
for _, i := range indexes {
printPanic(fmt.Sprintf("slice[%d]", i), func() {
_ = a[i]
})
}
b := [3]int{1, 2, 3}
for _, i := range indexes {
printPanic(fmt.Sprintf("array[%d]", i), func() {
_ = b[i]
})
}
c := "123"
for _, i := range indexes {
printPanic(fmt.Sprintf("string[%d]", i), func() {
_ = c[i]
})
}
}
func doSlice() {
a := []int{1, 2, 3}
for _, i := range slices {
for _, j := range slices {
printPanic(fmt.Sprintf("slice[%d:%d]", i, j), func() {
_ = a[i:j]
})
}
}
b := [3]int{1, 2, 3}
for _, i := range slices {
for _, j := range slices {
printPanic(fmt.Sprintf("array[%d:%d]", i, j), func() {
_ = b[i:j]
})
}
}
c := "123"
for _, i := range slices {
for _, j := range slices {
printPanic(fmt.Sprintf("string[%d:%d]", i, j), func() {
_ = c[i:j]
})
}
}
}
func doSlice3() {
a := []int{1, 2, 3}
for _, i := range slices {
for _, j := range slices {
for _, k := range slices {
printPanic(fmt.Sprintf("slice[%d:%d:%d]", i, j, k), func() {
_ = a[i:j:k]
})
}
}
}
b := [3]int{1, 2, 3}
for _, i := range slices {
for _, j := range slices {
for _, k := range slices {
printPanic(fmt.Sprintf("array[%d:%d:%d]", i, j, k), func() {
_ = b[i:j:k]
})
}
}
}
}
func printPanic(msg string, f func()) {
defer func() {
res := "no panic"
if e := recover(); e != nil {
res = e.(runtime.Error).Error()
}
fmt.Fprintf(w, "%s\t %s\n", msg, res)
}()
f()
}