mirror of
https://github.com/golang/go
synced 2024-11-17 02:34:46 -07:00
f582778ee9
Currently, the compiler will emit any const that doesn't fit in an
int64 to go_asm.h like
#define const_stackPreempt constant.intVal{val:(*big.Int)(0xc000c06c40)}
This happens because dumpasmhdr formats the constant.Value using the
verb "%#v". Since constant.Value doesn't implement the GoString()
method, this just prints the Go-syntax representation of the value.
This happens to work for small integer constants, which go/constant
represents directly as an int64, but not for integer constants that
don't fit in an int64, which go/constant represents as a big.Int.
Make these constants usable by changing the formatting verb to "%v",
which will call the String() method, giving a reasonable result in all
cases.
Change-Id: I365eeb88c8acfc43ff377cc873432269bde3f541
Reviewed-on: https://go-review.googlesource.com/c/go/+/359954
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
67 lines
1.5 KiB
Go
67 lines
1.5 KiB
Go
// Copyright 2021 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import "unsafe"
|
|
|
|
const (
|
|
smallInt = 42
|
|
|
|
// For bigInt, we use a value that's too big for an int64, but still
|
|
// fits in uint64. go/constant uses a different representation for
|
|
// values larger than int64, but the cmd/asm parser can't parse
|
|
// anything bigger than a uint64.
|
|
bigInt = 0xffffffffffffffff
|
|
|
|
stringVal = "test"
|
|
)
|
|
|
|
var (
|
|
smallIntAsm int64
|
|
bigIntAsm uint64
|
|
stringAsm [len(stringVal)]byte
|
|
)
|
|
|
|
type typ struct {
|
|
a uint64
|
|
b [100]uint8
|
|
c uint8
|
|
}
|
|
|
|
var (
|
|
typSize uint64
|
|
|
|
typA, typB, typC uint64
|
|
)
|
|
|
|
func main() {
|
|
if smallInt != smallIntAsm {
|
|
println("smallInt", smallInt, "!=", smallIntAsm)
|
|
}
|
|
if bigInt != bigIntAsm {
|
|
println("bigInt", uint64(bigInt), "!=", bigIntAsm)
|
|
}
|
|
if stringVal != string(stringAsm[:]) {
|
|
println("stringVal", stringVal, "!=", string(stringAsm[:]))
|
|
}
|
|
|
|
// We also include boolean consts in go_asm.h, but they're
|
|
// defined to be "true" or "false", and it's not clear how to
|
|
// use that in assembly.
|
|
|
|
if want := unsafe.Sizeof(typ{}); want != uintptr(typSize) {
|
|
println("typSize", want, "!=", typSize)
|
|
}
|
|
if want := unsafe.Offsetof(typ{}.a); want != uintptr(typA) {
|
|
println("typA", want, "!=", typA)
|
|
}
|
|
if want := unsafe.Offsetof(typ{}.b); want != uintptr(typB) {
|
|
println("typB", want, "!=", typB)
|
|
}
|
|
if want := unsafe.Offsetof(typ{}.c); want != uintptr(typC) {
|
|
println("typC", want, "!=", typC)
|
|
}
|
|
}
|